From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix <bits/mathcalls.h> __BEGIN_NAMESPACE_C99/__END_NAMESPACE_C99 pairing
Date: Wed, 01 Feb 2006 15:29:00 -0000 [thread overview]
Message-ID: <20060201152926.GA4625@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <20060201152453.GZ4625@sunsite.mff.cuni.cz>
On Wed, Feb 01, 2006 at 04:24:53PM +0100, Jakub Jelinek wrote:
> 2006-02-01 Jakub Jelinek <jakub@redhat.com>
>
> * math/bits/mathcalls.h: Guard __END_NAMESPACE_C99 with the
> same #if condition as corresponding __BEGIN_NAMESPACE_C99.
> (scalb): Don't define only if __USE_ISOC99.
Forgot to add, I did some testing to see if similar problems aren't
elsewhere:
#!/bin/sh
for i in `rpm -ql glibc-headers`; do perl /usr/src/libc/scripts/begin-end-check.pl $i; done 2>&1 | grep -v OK
for i in `rpm -ql glibc-headers`; do
cat > /tmp/a.c <<EOF
#include <features.h>
#undef __BEGIN_DECLS
#undef __END_DECLS
#undef __BEGIN_NAMESPACE_STD
#undef __END_NAMESPACE_STD
#undef __BEGIN_NAMESPACE_C99
#undef __END_NAMESPACE_C99
#include <$i>
EOF
gcc -E /tmp/a.c -o /tmp/a.i > /dev/null 2>&1 || continue;
for flags in "" -D_GNU_SOURCE -D_ISOC99_SOURCE -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_SVID_SOURCE -D_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_XOPEN_SOURCE=500 -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -ansi -D_POSIX_SOURCE -D_POSIX_C_SOURCE -D_POSIX_C_SOURCE=2 -D_POSIX_C_SOURCE=199309L -D_POSIX_C_SOURCE=199506L -D_POSIX_C_SOURCE=200112L; do
gcc $flags -E /tmp/a.c -o /tmp/a.i > /dev/null 2>&1;
perl /usr/src/libc/scripts/begin-end-check.pl /tmp/a.i | grep -v OK | sed "s~^~$i $flags: ~"
done
done
and math.h (plus tgmath.h that includes math.h) were the only 2 reported
headers.
Jakub
prev parent reply other threads:[~2006-02-01 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 15:25 Jakub Jelinek
2006-02-01 15:29 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060201152926.GA4625@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).