* [PATCH] SH tiny tweak
@ 2006-01-31 14:30 Kaz Kojima
2006-02-02 9:42 ` Roland McGrath
0 siblings, 1 reply; 3+ messages in thread
From: Kaz Kojima @ 2006-01-31 14:30 UTC (permalink / raw)
To: libc-hacker
Hi,
On SH, I've found an error when compiling nptl/tst-cancel24 with
the C++ compiler:
../include/setjmp.h:8: error: non-local function `void __longjmp(<anonymous struct>*, int)' uses anonymous type
but missed to send the attached patch to fix it.
Regards,
kaz
--
2006-01-31 Kaz Kojima <kkojima@rr.iij4u.or.jp>
* sysdeps/sh/bits/setjmp.h: Use the structure with tag.
diff -uprN ORIG/libc/sysdeps/sh/bits/setjmp.h LOCAL/libc/sysdeps/sh/bits/setjmp.h
--- ORIG/libc/sysdeps/sh/bits/setjmp.h 2006-01-19 08:45:42.000000000 +0900
+++ LOCAL/libc/sysdeps/sh/bits/setjmp.h 2006-01-31 14:30:59.000000000 +0900
@@ -25,7 +25,7 @@
#endif
#ifndef _ASM
-typedef struct
+typedef struct __jmp_buf_s
{
/* Callee-saved registers r8 through r15. */
int __regs[8];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SH tiny tweak
2006-01-31 14:30 [PATCH] SH tiny tweak Kaz Kojima
@ 2006-02-02 9:42 ` Roland McGrath
2006-02-02 12:26 ` Kaz Kojima
0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2006-02-02 9:42 UTC (permalink / raw)
To: Kaz Kojima; +Cc: libc-hacker
I made a change so that include/setjmp.h is not spuriously brought in for C++.
I'm concerned that your change might affect C++ name mangling for existing
C++ code using jmp_buf, but I'm not sure whether that is an issue or not.
Thanks,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SH tiny tweak
2006-02-02 9:42 ` Roland McGrath
@ 2006-02-02 12:26 ` Kaz Kojima
0 siblings, 0 replies; 3+ messages in thread
From: Kaz Kojima @ 2006-02-02 12:26 UTC (permalink / raw)
To: roland; +Cc: libc-hacker
Roland McGrath <roland@redhat.com> wrote:
>I made a change so that include/setjmp.h is not spuriously brought in for C++.
>I'm concerned that your change might affect C++ name mangling for existing
>C++ code using jmp_buf, but I'm not sure whether that is an issue or not.
Thanks! It gets rid of the compile time failure for test-cancel24
on SH.
Regards,
kaz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-02 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-31 14:30 [PATCH] SH tiny tweak Kaz Kojima
2006-02-02 9:42 ` Roland McGrath
2006-02-02 12:26 ` Kaz Kojima
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).