public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Thorsten Kukuk <kukuk@suse.de>
Cc: libc-hacker@sources.redhat.com
Subject: Re: __atfct_seterrno() or futimesat() broken
Date: Thu, 02 Feb 2006 10:15:00 -0000	[thread overview]
Message-ID: <20060202101544.476E1180988@magilla.sf.frob.com> (raw)
In-Reply-To: Thorsten Kukuk's message of  Saturday, 28 January 2006 17:55:11 +0100 <20060128165511.GA4000@suse.de>

I don't see how the lstat check that did the problematic string twiddling
was actually doing anything for us not better done by the fstat check for
the EBADF case.  I changed it to use the simple fstat check for EBADF on
ENOENT as well as ENOTDIR, which gets rid of the code with the bad
assumptions about the contents of BUF.  I also made it do the check for
missing /proc on ENOENT as well.  There are in fact many other potential
error codes that could be /proc is not mounted as expected, but ENOENT is
in fact the most likely one (and ENOTDIR possible, but not perhaps any more
likely than several others).


Thanks,
Roland

      reply	other threads:[~2006-02-02 10:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-28 16:55 Thorsten Kukuk
2006-02-02 10:15 ` Roland McGrath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060202101544.476E1180988@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=kukuk@suse.de \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).