From: "H. J. Lu" <hjl@lucon.org>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Roland McGrath <roland@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Avoid check-testrel failing on all sparc*, alpha or ppc32 -mbss-plt shared libraries
Date: Thu, 02 Mar 2006 18:30:00 -0000 [thread overview]
Message-ID: <20060302183039.GA29439@lucon.org> (raw)
In-Reply-To: <440716AF.5070601@redhat.com>
On Thu, Mar 02, 2006 at 08:00:47AM -0800, Ulrich Drepper wrote:
> I've applied the patch but this really cannot be a long-term solution.
> Either the arch goes away or it gets an ABI which isn't an open
> invitation for attackers.
>
It is broken since elf/check-textrel.c is compiled with
cd /export/build/gnu/glibc-nptl-4.1-redhat/build-x86_64-linux/elf && gcc -pipe -O -Wall -D_XOPEN_SOURCE=600 -D_BSD_SOURCE -include ../config.h /export/gnu/src/glibc/libc/elf/check-textrel.c -o check-textrel
/export/gnu/src/glibc/libc/elf/check-textrel.c:21:20: error: config.h:
No such file or directory
There is no need to include "config.h" since there is "-include
../config.h" already. This patch fixes it.
H.J.
----
2006-03-02 H.J. Lu <hongjiu.lu@intel.com>
* elf/check-textrel.c: Don't include "config.h".
--- elf/check-textrel.c.foo 2006-03-02 09:17:08.000000000 -0800
+++ elf/check-textrel.c 2006-03-02 10:14:10.000000000 -0800
@@ -18,7 +18,6 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */
-#include "config.h"
#include <byteswap.h>
#include <elf.h>
#include <endian.h>
next prev parent reply other threads:[~2006-03-02 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 14:54 Jakub Jelinek
2006-03-02 16:00 ` Ulrich Drepper
2006-03-02 18:30 ` H. J. Lu [this message]
2006-03-02 18:42 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302183039.GA29439@lucon.org \
--to=hjl@lucon.org \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).