public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Roland McGrath <roland@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Use __LONG_LONG_PAIR in linux/sync_file_range.c
Date: Mon, 24 Apr 2006 10:11:00 -0000	[thread overview]
Message-ID: <20060424101119.GD4651@sunsite.mff.cuni.cz> (raw)

Hi!

So far I think none of the 32-bit big endian arches support this syscall
(and ppc32 will likely need its own implementation of this, as it requires
long long args to be at padded to even arguments), but certainly it doesn't
hurt to follow what linux/posix_fadvise{,64}.c is already doing.

2006-04-24  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/sync_file_range.c (sync_file_range): Use
	__LONG_LONG_PAIR macro.

--- libc/sysdeps/unix/sysv/linux/sync_file_range.c	14 Apr 2006 08:07:56 -0000	1.1
+++ libc/sysdeps/unix/sysv/linux/sync_file_range.c	24 Apr 2006 10:01:53 -0000
@@ -29,9 +29,10 @@
 int
 sync_file_range (int fd, __off64_t from, __off64_t to, int flags)
 {
-  return INLINE_SYSCALL (sync_file_range, 6, fd, (off_t) (from >> 32),
-			 (off_t) (from & 0xffffffff), (off_t) (to >> 32),
-			 (off_t) (to & 0xffffffff), flags);
+  return INLINE_SYSCALL (sync_file_range, 6, fd,
+			 __LONG_LONG_PAIR ((long) (from >> 32), (long) from),
+			 __LONG_LONG_PAIR ((long) (to >> 32), (long) to),
+			 flags);
 }
 #else
 int

	Jakub

             reply	other threads:[~2006-04-24 10:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-24 10:11 Jakub Jelinek [this message]
2006-04-24 17:08 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060424101119.GD4651@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).