public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix uninitialized var in gai_suspend
Date: Wed, 06 Sep 2006 16:37:00 -0000	[thread overview]
Message-ID: <20060906163703.GU4556@sunsite.mff.cuni.cz> (raw)

Hi!

GAI_MISC_WAIT macro only sets result on error, so without this patch
we return an uninitialized value.

2006-09-06  Jakub Jelinek  <jakub@redhat.com>

	* resolv/gai_suspend.c (gai_suspend): Make sure result is initialized.

--- libc/resolv/gai_suspend.c.jj	2006-08-03 10:03:46.000000000 +0200
+++ libc/resolv/gai_suspend.c	2006-09-06 17:30:22.000000000 +0200
@@ -83,6 +83,7 @@ gai_suspend (const struct gaicb *const l
       pthread_setcancelstate (PTHREAD_CANCEL_DISABLE, &oldstate);
 
 #ifdef DONT_NEED_GAI_MISC_COND
+      result = 0;
       GAI_MISC_WAIT (result, cntr, timeout, 1);
 #else
       if (timeout == NULL)

	Jakub

             reply	other threads:[~2006-09-06 16:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-06 16:37 Jakub Jelinek [this message]
2006-09-06 16:49 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060906163703.GU4556@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).