From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>, Steven Munroe <munroesj@us.ibm.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix ppc* libSegFault.so register dump
Date: Fri, 15 Sep 2006 22:52:00 -0000 [thread overview]
Message-ID: <20060915225144.GJ4556@sunsite.mff.cuni.cz> (raw)
Hi!
For ppc32 this just removes '\0' character that has been printed after
the register dump and before the backtrace.
For ppc64 libSegFault.so printed complete garbage.
2006-09-16 Jakub Jelinek <jakub@redhat.com>
* sysdeps/powerpc/powerpc32/register-dump.h (register_dump): Don't
write '\0' to the fd.
* sysdeps/mach/hurd/powerpc/register-dump.h (register_dump): Likewise.
* sysdeps/powerpc/powerpc64/register-dump.h (register_dump): Likewise.
Change regs to unsigned long pointer from unsigned int, fix fscr offset.
--- libc/sysdeps/powerpc/powerpc64/register-dump.h.jj 2002-09-18 01:50:02.000000000 +0200
+++ libc/sysdeps/powerpc/powerpc64/register-dump.h 2006-09-16 00:43:48.000000000 +0200
@@ -1,5 +1,5 @@
/* Dump registers.
- Copyright (C) 1998, 2002 Free Software Foundation, Inc.
+ Copyright (C) 1998, 2002, 2006 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -34,7 +34,7 @@ gr16-19: 000000000000010% 00000000000001
gr20-23: 000000000000014% 000000000000015% 000000000000016% 000000000000017%\n\
gr24-27: 000000000000018% 000000000000019% 00000000000001a% 00000000000001b%\n\
gr28-31: 00000000000001c% 00000000000001d% 00000000000001e% 00000000000001f%\n\
-fscr=0000071%\n\
+fscr=000000000000050%\n\
fp0-3: 000000000000030% 000000000000031% 000000000000032% 000000000000033%\n\
fp4-7: 000000000000034% 000000000000035% 000000000000036% 000000000000037%\n\
fp8-11: 000000000000038% 000000000000038% 00000000000003a% 00000000000003b%\n\
@@ -104,7 +104,7 @@ register_dump (int fd, struct sigcontext
char buffer[sizeof(dumpform)];
char *bufferpos;
unsigned regno;
- unsigned *regs = (unsigned *)(ctx->regs);
+ unsigned long *regs = (unsigned long *)(ctx->regs);
memcpy(buffer, dumpform, sizeof(dumpform));
@@ -117,7 +117,7 @@ register_dump (int fd, struct sigcontext
}
/* Write the output. */
- write (fd, buffer, sizeof(buffer));
+ write (fd, buffer, sizeof(buffer) - 1);
}
--- libc/sysdeps/powerpc/powerpc32/register-dump.h.jj 2002-09-05 10:25:50.000000000 +0200
+++ libc/sysdeps/powerpc/powerpc32/register-dump.h 2006-09-16 00:44:07.000000000 +0200
@@ -1,5 +1,5 @@
/* Dump registers.
- Copyright (C) 1998 Free Software Foundation, Inc.
+ Copyright (C) 1998, 2006 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -113,7 +113,7 @@ register_dump (int fd, struct sigcontext
}
/* Write the output. */
- write (fd, buffer, sizeof(buffer));
+ write (fd, buffer, sizeof(buffer) - 1);
}
--- libc/sysdeps/mach/hurd/powerpc/register-dump.h.jj 2001-11-10 01:37:47.000000000 +0100
+++ libc/sysdeps/mach/hurd/powerpc/register-dump.h 2006-09-16 00:44:35.000000000 +0200
@@ -1,5 +1,5 @@
/* Dump registers. PowerPC/Hurd version.
- Copyright (C) 1998, 2001 Free Software Foundation, Inc.
+ Copyright (C) 1998, 2001, 2006 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -113,7 +113,7 @@ register_dump (int fd, struct sigcontext
}
/* Write the output. */
- write (fd, buffer, sizeof(buffer));
+ write (fd, buffer, sizeof(buffer) - 1);
}
#define REGISTER_DUMP \
Jakub
reply other threads:[~2006-09-15 22:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060915225144.GJ4556@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=munroesj@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).