From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix pthread_spin_unlock on ia64
Date: Mon, 30 Oct 2006 00:26:00 -0000 [thread overview]
Message-ID: <20061030002645.GT5868@sunsite.mff.cuni.cz> (raw)
Hi!
__sync_lock_release_si was an implementation detail of the old
<ia64intrin.h>'s __sync_lock_release macro. GCC 4.1.x+ supports
only __sync_lock_release.
Now the question is why this hasn't been seen before, I think perhaps
nptl/sysdeps/pthread could be searched before nptl/sysdeps/ia64.
2006-10-30 Jakub Jelinek <jakub@redhat.com>
* sysdeps/ia64/pthread_spin_unlock.c (pthread_spin_unlock): Use
__sync_lock_release instead of __sync_lock_release_si.
--- libc/nptl/sysdeps/ia64/pthread_spin_unlock.c 2003-03-18 04:42:45.000000000 +0100
+++ libc/nptl/sysdeps/ia64/pthread_spin_unlock.c 2006-10-30 00:31:16.000000000 +0100
@@ -1,4 +1,4 @@
-/* Copyright (C) 2003 Free Software Foundation, Inc.
+/* Copyright (C) 2003, 2006 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Jakub Jelinek <jakub@redhat.com>, 2003.
@@ -23,6 +23,6 @@
int
pthread_spin_unlock (pthread_spinlock_t *lock)
{
- __sync_lock_release_si ((int *) lock);
+ __sync_lock_release ((int *) lock);
return 0;
}
Jakub
reply other threads:[~2006-10-30 0:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030002645.GT5868@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).