public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix last svc_run change
Date: Thu, 30 Nov 2006 13:44:00 -0000	[thread overview]
Message-ID: <20061130134418.GE9556@sunsite.mff.cuni.cz> (raw)
In-Reply-To: <20061127191041.GA3484@sunsite.mff.cuni.cz>

On Mon, Nov 27, 2006 at 08:10:41PM +0100, Jakub Jelinek wrote:
> 2006-11-27  Jakub Jelinek  <jakub@redhat.com>
> 
> 	[BZ #3559]
> 	* sunrpc/svc_run.c (svc_run): Fail instead of segfaulting if
> 	malloc crashed.  Don't allocate memory unnecessarily in each
> 	loop.

Oops, brown paper bag bug in it, fixed thusly, tested with portmap:

2006-11-30  Jakub Jelinek  <jakub@redhat.com>

	* sunrpc/svc_run.c (svc_run): Set my_pollfd to new_pollfd if realloc
	succeeded.

--- libc/sunrpc/svc_run.c	27 Nov 2006 21:58:11 -0000	1.11
+++ libc/sunrpc/svc_run.c	30 Nov 2006 13:41:18 -0000
@@ -71,6 +71,7 @@ svc_run (void)
 	      break;
 	    }
 
+	  my_pollfd = new_pollfd;
 	  last_max_pollfd = max_pollfd;
 	}
 


	Jakub

      reply	other threads:[~2006-11-30 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-27 19:11 [PATCH] Fix svc_run Jakub Jelinek
2006-11-30 13:44 ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061130134418.GE9556@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).