public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Fix tst-pselect failure handling
Date: Thu, 14 Dec 2006 17:20:00 -0000	[thread overview]
Message-ID: <20061214172036.GJ3819@sunsite.mff.cuni.cz> (raw)

Hi!

When tst-pselect.c fails (quite often when running on kernel that
doesn't have pselect6 syscall, because pselect is then not atomic,
but even 2.6.18 x86_64 kernel it fails rather quickly with pselect6
syscall when running while misc/tst-pselect; do :; done), test-skeleton.c
only kills its immediate child, while the other child sticks around
forever.

The following patch is one possibility to avoid this:

2006-12-14  Jakub Jelinek  <jakub@redhat.com>

	* misc/tst-pselect.c (do_test): Break the child loop if
	parent was killed by timeout handler.

--- libc/misc/tst-pselect.c.jj	2006-09-18 09:11:59.000000000 +0200
+++ libc/misc/tst-pselect.c	2006-12-14 16:35:33.000000000 +0100
@@ -61,12 +61,15 @@ do_test (void)
       FD_SET (fds[0][0], &rfds);
 
       int e;
+      /* Break the loop if our parent is killed by test-skeleton.c's
+	 timeout handler.  */
+      pid_t ppid = getppid ();
       do
 	{
 	  errno = 0;
 	  e = pselect (fds[0][0] + 1, &rfds, NULL, NULL, &to, &ss);
 	}
-      while (e == 0);
+      while (e == 0 && getppid () == ppid);
 
       if (e != -1)
 	{

	Jakub

                 reply	other threads:[~2006-12-14 17:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061214172036.GJ3819@sunsite.mff.cuni.cz \
    --to=jakub@redhat.com \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).