From: Jakub Jelinek <jakub@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: [PATCH] Misc small warning fixes
Date: Mon, 28 May 2007 13:49:00 -0000 [thread overview]
Message-ID: <20070528135112.GK3081@sunsite.mff.cuni.cz> (raw)
Hi!
When __NR_utimensat is not defined, gcc warns about miss_utimensat being
defined, but never used.
And without the second hunk __getpagesize is implicitly prototyped in PPCs
pthread_attr_setstacksize.
2007-05-28 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/futimes.c (miss_utimensat): Don't define
if __NR_utimensat is not defined.
* sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c: Include
unistd.h.
--- libc/sysdeps/unix/sysv/linux/futimes.c.jj 2007-05-28 15:07:37.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/futimes.c 2007-05-28 15:07:37.000000000 +0200
@@ -1,5 +1,5 @@
/* futimes -- change access and modification times of open file. Linux version.
- Copyright (C) 2002,2003,2005,2006 Free Software Foundation, Inc.
+ Copyright (C) 2002,2003,2005,2006,2007 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -29,7 +29,7 @@
#include <kernel-features.h>
-#ifndef __ASSUME_UTIMENSAT
+#if defined __NR_utimensat && !defined __ASSUME_UTIMENSAT
static int miss_utimensat;
#endif
--- libc/nptl/sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c.jj 2006-10-07 21:51:33.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/powerpc/pthread_attr_setstacksize.c 2007-05-28 15:16:12.000000000 +0200
@@ -1,3 +1,4 @@
+#include <unistd.h> /* For __getpagesize. */
#define NEW_VERNUM GLIBC_2_6
#define STACKSIZE_ADJUST \
do { \
Jakub
reply other threads:[~2007-05-28 13:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070528135112.GK3081@sunsite.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).