[PATCH] Define PI_STATIC_AND_HIDDEN on IA-64, add check for it for Alpha

[PATCH] Define PI_STATIC_AND_HIDDEN on IA-64, add check for it for Alpha

[Jakub Jelinek]

Hi!

All IA-64 compilers which support HAVE_VISIBILITY_ATTRIBUTE
make GP relative relocs for static and hidden vars, on Alpha similarly
with the exception of Red Hat gcc-3.2-2 and earlier.

2002-08-28  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/ia64/elf/configure.in (PI_STATIC_AND_HIDDEN): Define
	unconditionally.
	* sysdeps/ia64/elf/configure: Rebuilt.
	* sysdeps/alpha/elf/configure.in (libc_cv_alpha_hidden_gprel): New
	check.
	(PI_STATIC_AND_HIDDEN): Define if check succeeded.
	* sysdeps/alpha/elf/configure: Rebuilt.

--- libc/sysdeps/ia64/elf/configure.in.jj	2002-08-28 22:13:57.000000000 +0200
+++ libc/sysdeps/ia64/elf/configure.in	2002-08-28 22:14:28.000000000 +0200
@@ -0,0 +1,7 @@
+sinclude(./aclocal.m4)dnl Autoconf lossage
+GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
+# Local configure fragment for sysdeps/ia64/elf.
+
+dnl It is always possible to access static and hidden symbols in an
+dnl position independent way.
+AC_DEFINE(PI_STATIC_AND_HIDDEN)
--- libc/sysdeps/ia64/elf/configure.jj	2002-08-28 22:14:39.000000000 +0200
+++ libc/sysdeps/ia64/elf/configure	2002-08-28 22:14:55.000000000 +0200
@@ -0,0 +1,6 @@
+ # Local configure fragment for sysdeps/ia64/elf.
+
+cat >> confdefs.h <<\EOF
+#define PI_STATIC_AND_HIDDEN 1
+EOF
+
--- libc/sysdeps/alpha/elf/configure.in.jj	2002-06-04 21:02:43.000000000 +0200
+++ libc/sysdeps/alpha/elf/configure.in	2002-08-28 22:29:21.000000000 +0200
@@ -51,3 +51,29 @@ if test $libc_cv_alpha_tls = yes; then
   AC_DEFINE(HAVE_TLS_SUPPORT)
 fi
 fi
+
+AC_CACHE_CHECK(for GP relative module local relocs, libc_cv_alpha_hidden_gprel, [dnl
+cat > conftest.c <<\EOF
+static int bar;
+int baz __attribute__((visibility("hidden")));
+
+int foo (void)
+{
+  return bar + baz;
+}
+EOF
+dnl
+
+libc_cv_alpha_hidden_gprel=no
+if AC_TRY_COMMAND(${CC-cc} -S $CFLAGS -O2 -fpic conftest.c 1>&AC_FD_CC); then
+  if grep -q 'bar.*!gprel' conftest.s \
+     && grep -q 'baz.*!gprel' conftest.s \
+     && ! grep -q 'bar.*!literal' conftest.s \
+     && ! grep -q 'baz.*!literal' conftest.s; then
+    libc_cv_alpha_hidden_gprel=yes
+  fi
+fi
+rm -f conftest*])
+if test $libc_cv_alpha_hidden_gprel = yes; then
+  AC_DEFINE(PI_STATIC_AND_HIDDEN)
+fi
--- libc/sysdeps/alpha/elf/configure.jj	2002-06-05 10:55:48.000000000 +0200
+++ libc/sysdeps/alpha/elf/configure	2002-08-28 22:33:13.000000000 +0200
@@ -58,3 +58,38 @@ EOF
 
 fi
 fi
+
+echo $ac_n "checking for GP relative module local relocs""... $ac_c" 1>&6
+echo "configure:20: checking for GP relative module local relocs" >&5
+if eval "test \"`echo '$''{'libc_cv_alpha_hidden_gprel'+set}'`\" = set"; then
+  echo $ac_n "(cached) $ac_c" 1>&6
+else
+  cat > conftest.c <<\EOF
+static int bar;
+int baz __attribute__((visibility("hidden")));
+
+int foo (void)
+{
+  return bar + baz;
+}
+EOF
+
+libc_cv_alpha_hidden_gprel=no
+if { ac_try='${CC-cc} -S $CFLAGS -O2 -fpic conftest.c 1>&5'; { (eval echo configure:35: \"$ac_try\") 1>&5; (eval $ac_try) 2>&5; }; }; then
+  if grep -q 'bar.*!gprel' conftest.s \
+     && grep -q 'baz.*!gprel' conftest.s \
+     && ! grep -q 'bar.*!literal' conftest.s \
+     && ! grep -q 'baz.*!literal' conftest.s; then
+    libc_cv_alpha_hidden_gprel=yes
+  fi
+fi
+rm -f conftest*
+fi
+
+echo "$ac_t""$libc_cv_alpha_hidden_gprel" 1>&6
+if test $libc_cv_alpha_hidden_gprel = yes; then
+  cat >> confdefs.h <<\EOF
+#define PI_STATIC_AND_HIDDEN 1
+EOF
+
+fi

	Jakub

Re: [PATCH] Define PI_STATIC_AND_HIDDEN on IA-64, add check for it for Alpha

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jakub Jelinek wrote:

> 2002-08-28  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* sysdeps/ia64/elf/configure.in (PI_STATIC_AND_HIDDEN): Define
> 	unconditionally.
> 	* sysdeps/ia64/elf/configure: Rebuilt.
> 	* sysdeps/alpha/elf/configure.in (libc_cv_alpha_hidden_gprel): New
> 	check.
> 	(PI_STATIC_AND_HIDDEN): Define if check succeeded.
> 	* sysdeps/alpha/elf/configure: Rebuilt.

I've applied the patch.  Thanks,

- -- 
- ---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE9bUwC2ijCOnn/RHQRAsz7AKCD2JuFWdVz01+BtydW3KY/6EXZawCgyr77
qdDpciAphGVfuRqIqRYR1z4=
=jvmi
-----END PGP SIGNATURE-----