* [PATCH] x86_64 dl-machine.h fix
@ 2003-02-21 16:09 Jakub Jelinek
2003-02-21 19:29 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2003-02-21 16:09 UTC (permalink / raw)
To: Ulrich Drepper, Roland McGrath; +Cc: Glibc hackers
Hi!
R_X86_64_PC32 is sword32, not uword32...
2003-02-21 Jakub Jelinek <jakub@redhat.com>
* sysdeps/x86_64/dl-machine.h (elf_machine_rela) <R_X86_64_PC32>:
Check for signed overflow, not unsigned.
--- libc/sysdeps/x86_64/dl-machine.h.jj 2002-10-21 13:15:01.000000000 -0400
+++ libc/sysdeps/x86_64/dl-machine.h 2003-02-21 11:05:47.000000000 -0500
@@ -1,5 +1,5 @@
/* Machine-dependent ELF dynamic relocation inline functions. x86-64 version.
- Copyright (C) 2001, 2002 Free Software Foundation, Inc.
+ Copyright (C) 2001, 2002, 2003 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Andreas Jaeger <aj@suse.de>.
@@ -463,7 +463,7 @@ elf_machine_rela (struct link_map *map,
*(unsigned int *) reloc_addr = value + reloc->r_addend
- (Elf64_Addr) reloc_addr;
if (value + reloc->r_addend - (Elf64_Addr) reloc_addr
- != (unsigned int)(value + reloc->r_addend - (Elf64_Addr) reloc_addr))
+ != (int)(value + reloc->r_addend - (Elf64_Addr) reloc_addr))
{
const char *strtab;
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86_64 dl-machine.h fix
2003-02-21 16:09 [PATCH] x86_64 dl-machine.h fix Jakub Jelinek
@ 2003-02-21 19:29 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2003-02-21 19:29 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Roland McGrath, Glibc hackers
Jakub Jelinek wrote:
> R_X86_64_PC32 is sword32, not uword32...
Applied. Thanks,
--
--------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-02-21 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-21 16:09 [PATCH] x86_64 dl-machine.h fix Jakub Jelinek
2003-02-21 19:29 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).