posix_fadvise() on ia64 and Alpha

posix_fadvise() on ia64 and Alpha

[Jes Sorensen]

Whoops did it again - trying the right address this time.

Hi,

Ray Bry pointed out to me that there is a disreprency between the
glibc ia64 (and I noticed Alpha as well) definitions of
POSIX_FADV_DONTNEED and POSIX_FADV_NOREUSE compared to the kernel.

Anyone know if there is a deliberate reason for this or if it was a
mistake? I wont rule out that I blindly copied over the changes from
the Alpha back when I introduced the file, but it's been a while.

Anyway, for the case that it's unintentional, patch included (2.2),
should apply cleanly to 2.3 as well.

Cheers,
Jes

2003-04-18    <jes@wildopensource.com>

	* libc/sysdeps/unix/sysv/linux/ia64/bits/fcntl.h: Sync with Linux
	2.5.67.
	* libc/sysdeps/unix/sysv/linux/alpha/bits/fcntl.h: Likewise.

--- sysdeps/unix/sysv/linux/ia64/bits/fcntl.h.~1.4.~	Fri Jul  6 00:56:17 2001
+++ sysdeps/unix/sysv/linux/ia64/bits/fcntl.h	Fri Apr 18 16:55:49 2003
@@ -169,6 +169,6 @@
 # define POSIX_FADV_RANDOM	1 /* Expect random page references.  */
 # define POSIX_FADV_SEQUENTIAL	2 /* Expect sequential page references.	 */
 # define POSIX_FADV_WILLNEED	3 /* Will need these pages.  */
-# define POSIX_FADV_DONTNEED	6 /* Don't need these pages.  */
-# define POSIX_FADV_NOREUSE	7 /* Data will be accessed once.  */
+# define POSIX_FADV_DONTNEED	4 /* Don't need these pages.  */
+# define POSIX_FADV_NOREUSE	5 /* Data will be accessed once.  */
 #endif
--- sysdeps/unix/sysv/linux/alpha/bits/fcntl.h.~1.14.~	Fri Jul  6 00:56:13 2001
+++ sysdeps/unix/sysv/linux/alpha/bits/fcntl.h	Fri Apr 18 16:57:48 2003
@@ -168,6 +168,6 @@
 # define POSIX_FADV_RANDOM	1 /* Expect random page references.  */
 # define POSIX_FADV_SEQUENTIAL	2 /* Expect sequential page references.  */
 # define POSIX_FADV_WILLNEED	3 /* Will need these pages.  */
-# define POSIX_FADV_DONTNEED	6 /* Don't need these pages.  */
-# define POSIX_FADV_NOREUSE	7 /* Data will be accessed once.  */
+# define POSIX_FADV_DONTNEED	4 /* Don't need these pages.  */
+# define POSIX_FADV_NOREUSE	5 /* Data will be accessed once.  */
 #endif

Re: posix_fadvise() on ia64 and Alpha

[Ulrich Drepper]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jes Sorensen wrote:

> Anyone know if there is a deliberate reason for this or if it was a
> mistake? I wont rule out that I blindly copied over the changes from
> the Alpha back when I introduced the file, but it's been a while.

I definitely think you copied the Alpha values.  And the only reason I
could think of why the Alpha values are what we have now is because of
OSF.  Maybe.  In any case, it must change, there is no value in
diverging from the kernel.  I applied the patch.  Thanks,

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+oZZo2ijCOnn/RHQRAhW/AKCH1atQrZYbhAgMn6dGaEKcEllhZgCffpt7
mRJjhJmnH7cT0oBpQy7i9ck=
=iFWy
-----END PGP SIGNATURE-----