public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Add static_link_warning to dlopen
@ 2003-09-19 20:36 Jakub Jelinek
  2003-09-19 20:41 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2003-09-19 20:36 UTC (permalink / raw)
  To: Ulrich Drepper, Roland McGrath; +Cc: Glibc hackers

Hi!

Using dlopen in statically linked apps has the same problems as using
NSS/iconv, so we should warn about it too.
Well, there might be an exception if the statically linked program
is dlopening libraries which are self-contained and don't need anything
from glibc (e.g. by using callbacks into the statically linked program),
but I guess it is so rare compared to the libs which actually need
libc that it should be warned always.

2003-09-19  Jakub Jelinek  <jakub@redhat.com>

	* dlfcn/dlopen.c (dlopen): Add static_link_warning.

--- libc/dlfcn/dlopen.c.jj	2001-07-06 00:54:45.000000000 -0400
+++ libc/dlfcn/dlopen.c	2003-09-19 16:08:44.000000000 -0400
@@ -54,3 +54,4 @@ __dlopen_check (const char *file, int mo
 }
 #include <shlib-compat.h>
 versioned_symbol (libdl, __dlopen_check, dlopen, GLIBC_2_1);
+static_link_warning (dlopen)

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add static_link_warning to dlopen
  2003-09-19 20:36 [PATCH] Add static_link_warning to dlopen Jakub Jelinek
@ 2003-09-19 20:41 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2003-09-19 20:41 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Roland McGrath, Glibc hackers

Jakub Jelinek wrote:

> Using dlopen in statically linked apps has the same problems as using
> NSS/iconv, so we should warn about it too.

Applied.

-- 
--------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-09-19 20:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-19 20:36 [PATCH] Add static_link_warning to dlopen Jakub Jelinek
2003-09-19 20:41 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).