public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Avoid mtracing linuxthreads threaded apps
@ 2004-02-20 18:58 Jakub Jelinek
  2004-02-20 20:29 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2004-02-20 18:58 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: Glibc hackers

Hi!

It just doesn't work reliably, linuxthreads sometimes doesn't free
more than those 3 objects depending on the exact order of events when
exiting.

2004-02-20  Jakub Jelinek  <jakub@redhat.com>

	* Makefile (generated): Remove tst-stack1.mtrace and tst-stack1-mem.
	(tests): Remove $(objpfx)tst-stack1-mem.
	(tst-stack1-ENV): Remove.
	($(objpfx)tst-stack1-mem): Remove.

--- libc/linuxthreads/Makefile.jj	2004-02-19 17:50:34.000000000 +0100
+++ libc/linuxthreads/Makefile	2004-02-20 20:54:55.004992264 +0100
@@ -116,8 +116,6 @@ test-srcs = tst-signal
 # These tests are linked with libc before libpthread
 tests-reverse += tst-cancel5
 
-generated += tst-stack1.mtrace tst-stack1-mem
-
 ifeq ($(build-static),yes)
 tests += tststatic tst-static-locale tst-cancel-static
 tests-static += tststatic tst-static-locale tst-cancel-static
@@ -144,15 +142,6 @@ tst-tls1modd.so-no-z-defs = yes
 tst-tls1mode.so-no-z-defs = yes
 tst-tls1modf.so-no-z-defs = yes
 
-tests: $(objpfx)tst-stack1-mem
-tst-stack1-ENV = MALLOC_TRACE=$(objpfx)tst-stack1.mtrace
-
-# There are still up to 3 objects unfreed:
-# manager thread's stack, tls block and dtv
-$(objpfx)tst-stack1-mem: $(objpfx)tst-stack1.out
-	$(common-objpfx)malloc/mtrace $(objpfx)tst-stack1.mtrace > $@ \
-	|| [ `grep ^0 $@ | wc -l` -le 3 ]
-
 $(test-modules): $(objpfx)%.so: $(objpfx)%.os $(common-objpfx)shlib.lds
 	$(build-module)
 

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Avoid mtracing linuxthreads threaded apps
  2004-02-20 18:58 [PATCH] Avoid mtracing linuxthreads threaded apps Jakub Jelinek
@ 2004-02-20 20:29 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2004-02-20 20:29 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Glibc hackers

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Applied.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFANm352ijCOnn/RHQRAmNPAJ4s6lUyyqfgYkUNRBE9txGEKaFK3gCdFPXn
LNNdXGDrZC6Mv3EhpBWLo3M=
=4UNL
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-20 20:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-20 18:58 [PATCH] Avoid mtracing linuxthreads threaded apps Jakub Jelinek
2004-02-20 20:29 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).