public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Hopefully fix sparc32 (non-v9) build
@ 2004-02-19  0:21 Jakub Jelinek
  2004-02-20 20:32 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2004-02-19  0:21 UTC (permalink / raw)
  To: Ulrich Drepper, tcallawa; +Cc: Glibc hackers

Hi!

Tom, can you please try the following patch?
My debugging revealed that .bss was made SEC_LOAD because of
.gnu.linkonce.b.__sparc32_atomic_locks section was not marked SHT_NOBITS
as it should (due to the braindamaged Sun .section directive variant
which doesn't have @nobits).

2004-02-19  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/sparc/sparc32/bits/atomic.h: Add __make_section_unallocated
	for .gnu.linkonce.b.__sparc32_atomic_locks section.
	(__sparc32_atomic_locks): Add __sec_comment at the end of section name.

--- libc/sysdeps/sparc/sparc32/bits/atomic.h.jj	2003-08-15 14:39:00.000000000 +0200
+++ libc/sysdeps/sparc/sparc32/bits/atomic.h	2004-02-19 02:16:37.901274552 +0100
@@ -1,5 +1,5 @@
 /* Atomic operations.  sparc32 version.
-   Copyright (C) 2003 Free Software Foundation, Inc.
+   Copyright (C) 2003, 2004 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Jakub Jelinek <jakub@redhat.com>, 2003.
 
@@ -26,8 +26,12 @@
    per library and assumes no variable will be accessed using atomic.h
    macros from two different libraries.  */
 
+__make_section_unallocated
+  (".gnu.linkonce.b.__sparc32_atomic_locks, \"aw\", %nobits");
+
 volatile unsigned char __sparc32_atomic_locks[64]
-  __attribute__ ((nocommon, section (".gnu.linkonce.b.__sparc32_atomic_locks"),
+  __attribute__ ((nocommon, section (".gnu.linkonce.b.__sparc32_atomic_locks"
+				     __sec_comment),
 		  visibility ("hidden")));
 
 #define __sparc32_atomic_do_lock(addr) \

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Hopefully fix sparc32 (non-v9) build
  2004-02-19  0:21 [PATCH] Hopefully fix sparc32 (non-v9) build Jakub Jelinek
@ 2004-02-20 20:32 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2004-02-20 20:32 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: tcallawa, Glibc hackers

Applied.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-20 20:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-19  0:21 [PATCH] Hopefully fix sparc32 (non-v9) build Jakub Jelinek
2004-02-20 20:32 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).