public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* Fix lvalue casts in elf/dl-load.c
@ 2004-02-21 15:44 Andreas Jaeger
  2004-02-21 18:16 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Jaeger @ 2004-02-21 15:44 UTC (permalink / raw)
  To: Glibc hackers

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]


The appended patch removes the with GCC 3.5 deprecated lvalue casts
and generates the same assembler code (tested with GCC 3.3
hammer-branch on AMD64).

Ok to commit?

Andreas

2004-02-21  Andreas Jaeger  <aj@suse.de>

	* elf/dl-load.c (_dl_map_object_from_fd): Fix casts used as lvalue.

============================================================
Index: elf/dl-load.c
--- elf/dl-load.c	9 Feb 2004 07:03:48 -0000	1.235
+++ elf/dl-load.c	21 Feb 2004 15:42:44 -0000
@@ -1228,7 +1228,7 @@ cannot allocate TLS data structures for 
       }
     else
       /* Adjust the PT_PHDR value by the runtime load address.  */
-      (ElfW(Addr)) l->l_phdr += l->l_addr;
+      l->l_phdr = (ElfW(Phdr) *) ((ElfW(Addr)) l->l_phdr + l->l_addr);
   }
 
 #ifdef USE_TLS
@@ -1254,7 +1254,7 @@ cannot allocate TLS data structures for 
 	}
     }
   else
-    (ElfW(Addr)) l->l_ld += l->l_addr;
+    l->l_ld = (ElfW(Dyn) *) ((ElfW(Addr)) l->l_ld + l->l_addr);
 
   l->l_entry += l->l_addr;
 

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix lvalue casts in elf/dl-load.c
  2004-02-21 15:44 Fix lvalue casts in elf/dl-load.c Andreas Jaeger
@ 2004-02-21 18:16 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2004-02-21 18:16 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: Glibc hackers

Andreas Jaeger wrote:

> Ok to commit?

Yes.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-21 18:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-21 15:44 Fix lvalue casts in elf/dl-load.c Andreas Jaeger
2004-02-21 18:16 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).