public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* sysdeps/powerpc/elf/rtld-global-offsets.sym
@ 2004-03-07 11:37 Andreas Jaeger
  2004-03-07 11:43 ` sysdeps/powerpc/elf/rtld-global-offsets.sym Andreas Jaeger
  2004-03-07 20:00 ` sysdeps/powerpc/elf/rtld-global-offsets.sym Ulrich Drepper
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Jaeger @ 2004-03-07 11:37 UTC (permalink / raw)
  To: Glibc hackers; +Cc: Steven Munroe

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]


Looking at the recent changes, I guess this file needs to be changed
with the following patch.

Can anybody test this on powerpc, please?

Andreas

2004-03-07  Andreas Jaeger  <aj@suse.de>

	* sysdeps/powerpc/elf/rtld-global-offsets.sym: Use _dl_hwcap is in
	rtld_global_ro.

============================================================
Index: sysdeps/powerpc/elf/rtld-global-offsets.sym
--- sysdeps/powerpc/elf/rtld-global-offsets.sym	16 Jan 2004 04:43:46 -0000	1.1
+++ sysdeps/powerpc/elf/rtld-global-offsets.sym	7 Mar 2004 11:36:31 -0000
@@ -2,6 +2,6 @@
 
 #include <ldsodefs.h>
 
-#define rtdl_global_offsetof(mem) offsetof (struct rtld_global, mem)
+#define rtdl_global_offsetof(mem) offsetof (struct rtld_global_ro, mem)
 
 RTLD_GLOBAL_DL_HWCAP_OFFSET	rtdl_global_offsetof (_dl_hwcap)

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: sysdeps/powerpc/elf/rtld-global-offsets.sym
  2004-03-07 11:37 sysdeps/powerpc/elf/rtld-global-offsets.sym Andreas Jaeger
@ 2004-03-07 11:43 ` Andreas Jaeger
  2004-03-07 20:00 ` sysdeps/powerpc/elf/rtld-global-offsets.sym Ulrich Drepper
  1 sibling, 0 replies; 3+ messages in thread
From: Andreas Jaeger @ 2004-03-07 11:43 UTC (permalink / raw)
  To: Glibc hackers; +Cc: Steven Munroe

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]


This might need also changes in the assembler code, where powerpc
uses:

	lwz     r5,_rtld_global@got(r5)
	mtlr    r6
	lwz     r5,RTLD_GLOBAL_DL_HWCAP_OFFSET(r5)

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: sysdeps/powerpc/elf/rtld-global-offsets.sym
  2004-03-07 11:37 sysdeps/powerpc/elf/rtld-global-offsets.sym Andreas Jaeger
  2004-03-07 11:43 ` sysdeps/powerpc/elf/rtld-global-offsets.sym Andreas Jaeger
@ 2004-03-07 20:00 ` Ulrich Drepper
  1 sibling, 0 replies; 3+ messages in thread
From: Ulrich Drepper @ 2004-03-07 20:00 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: Glibc hackers, Steven Munroe

Andreas Jaeger wrote:
> Looking at the recent changes, I guess this file needs to be changed
> with the following patch.

I've checked in some changes.  Untested since I don't have such a
machine, but it should work unless there is a magical difference between
_rtld_global and _rtld_global_ro.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-03-07 20:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-07 11:37 sysdeps/powerpc/elf/rtld-global-offsets.sym Andreas Jaeger
2004-03-07 11:43 ` sysdeps/powerpc/elf/rtld-global-offsets.sym Andreas Jaeger
2004-03-07 20:00 ` sysdeps/powerpc/elf/rtld-global-offsets.sym Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).