* [PATCH] Fix pthread_cond_broadcast on s390/s390x
@ 2004-06-22 11:30 Jakub Jelinek
2004-06-28 4:49 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2004-06-22 11:30 UTC (permalink / raw)
To: Ulrich Drepper, Martin Schwidefsky; +Cc: Glibc hackers
Hi!
This pasto caused in the better case most of FUTEX_CMP_REQUEUE calls return
-EAGAIN, but if unlucky it might even succeed when it was supposed to fail.
Tested on both s390 and s390x.
2004-06-22 Jakub Jelinek <jakub@redhat.com>
* sysdeps/unix/sysv/linux/s390/lowlevellock.h (lll_futex_requeue):
Set __r7 to val, not mutex.
--- libc/nptl/sysdeps/unix/sysv/linux/s390/lowlevellock.h.jj 2004-06-11 14:45:53.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/s390/lowlevellock.h 2004-06-22 13:26:54.911154237 +0200
@@ -91,7 +91,7 @@
register unsigned long int __r4 asm ("4") = (long int) (nr_wake); \
register unsigned long int __r5 asm ("5") = (long int) (nr_move); \
register unsigned long int __r6 asm ("6") = (unsigned long int) (mutex); \
- register unsigned long int __r7 asm ("7") = (int) (mutex); \
+ register unsigned long int __r7 asm ("7") = (int) (val); \
register unsigned long __result asm ("2"); \
\
__asm __volatile ("svc %b1" \
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix pthread_cond_broadcast on s390/s390x
2004-06-22 11:30 [PATCH] Fix pthread_cond_broadcast on s390/s390x Jakub Jelinek
@ 2004-06-28 4:49 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2004-06-28 4:49 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Martin Schwidefsky, Glibc hackers
Applied.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA â–
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-28 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-06-22 11:30 [PATCH] Fix pthread_cond_broadcast on s390/s390x Jakub Jelinek
2004-06-28 4:49 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).