* AC_DEFINE(HAVE_INLINED_SYSCALLS)
@ 2004-07-06 22:57 Roland McGrath
2004-07-07 6:05 ` AC_DEFINE(HAVE_INLINED_SYSCALLS) Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Roland McGrath @ 2004-07-06 22:57 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: GNU libc hackers
Using config.h defines should really be avoided whenever possible,
and preferably reserved entirely for things set by autoconf checks.
Unless there is a special reason I am overlooking, please revert this:
* sysdeps/unix/sysv/linux/configure.in: Define HAVE_INLINED_SYSCALLS.
* config.h.in: Add entry for HAVE_INLINED_SYSCALLS.
and instead put #define HAVE_INLINED_SYSCALLS into sysdep.h files.
Thanks,
Roland
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: AC_DEFINE(HAVE_INLINED_SYSCALLS)
2004-07-06 22:57 AC_DEFINE(HAVE_INLINED_SYSCALLS) Roland McGrath
@ 2004-07-07 6:05 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2004-07-07 6:05 UTC (permalink / raw)
To: Roland McGrath; +Cc: GNU libc hackers
The reason for using config.h is to not requiring to include sysdep.h in
files where it is not needed. That is a potentially quite expensive to
use header. And I honestly don't see problems with using config.h. I
think such general platform-specific defines are indeed well kept in
this file.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA â–
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-07 6:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-06 22:57 AC_DEFINE(HAVE_INLINED_SYSCALLS) Roland McGrath
2004-07-07 6:05 ` AC_DEFINE(HAVE_INLINED_SYSCALLS) Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).