* [PATCH] Kill memmove PLT slot on s390x
@ 2005-07-12 21:14 Jakub Jelinek
2005-07-12 21:22 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2005-07-12 21:14 UTC (permalink / raw)
To: Ulrich Drepper, Martin Schwidefsky; +Cc: Glibc hackers
Hi!
bcopy.os is the only object with
U memmove
on s390x. There is another unnecessary PLT slot on both s390 and s390x
- ffs, but that looks like a compiler bug.
2005-07-12 Jakub Jelinek <jakub@redhat.com>
* sysdeps/s390/s390-64/bcopy.S (__bcopy): Use
HIDDEN_BUILTIN_JUMPTARGET to jump to memmove.
--- libc/sysdeps/s390/s390-64/bcopy.S.jj 2001-07-16 08:29:42.000000000 +0200
+++ libc/sysdeps/s390/s390-64/bcopy.S 2005-07-12 22:54:12.000000000 +0200
@@ -1,6 +1,6 @@
/* bcopy -- copy a block from source to destination. 64 bit S/390 version.
This file is part of the GNU C Library.
- Copyright (C) 2000, 2001 Free Software Foundation, Inc.
+ Copyright (C) 2000, 2001, 2005 Free Software Foundation, Inc.
Contributed by Martin Schwidefsky (schwidefsky@de.ibm.com).
The GNU C Library is free software; you can redistribute it and/or
@@ -59,14 +59,10 @@ ENTRY(__bcopy)
jo .L6
br %r14
.L7: # destructive overlay, can not use mvcle
- lgr %r1,%r2 # bcopy is called with source,dest
- lgr %r2,%r3 # memmove with dest,source! Oh, well...
- lgr %r3,%r1
-#ifdef PIC
- jg memmove@PLT
-#else
- jg memmove
-#endif
+ lgr %r1,%r2 # bcopy is called with source,dest
+ lgr %r2,%r3 # memmove with dest,source! Oh, well...
+ lgr %r3,%r1
+ jg HIDDEN_BUILTIN_JUMPTARGET(memmove)
END(__bcopy)
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Kill memmove PLT slot on s390x
2005-07-12 21:14 [PATCH] Kill memmove PLT slot on s390x Jakub Jelinek
@ 2005-07-12 21:22 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2005-07-12 21:22 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Martin Schwidefsky, Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Applied.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-12 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-12 21:14 [PATCH] Kill memmove PLT slot on s390x Jakub Jelinek
2005-07-12 21:22 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).