public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] fixes for latest checkins
@ 2005-07-21 12:55 Thorsten Kukuk
  2005-07-21 16:21 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Kukuk @ 2005-07-21 12:55 UTC (permalink / raw)
  To: libc-hacker


Hi,

I got two compiler warnings from the latest checkins, __getgroups_chk
has the wrong return value (should be int, not char *) and fxprintf.c
is missing a string.h include:

2005-07-21  Thorsten Kukuk  <kukuk@suse.de>

	* debug/getgroups_chk.c (__getgroups_chk): Fix return value.

	* stdio-common/fxprintf.c: Include string.h.

--- debug/getgroups_chk.c	18 Jul 2005 20:56:52 -0000	1.1
+++ debug/getgroups_chk.c	21 Jul 2005 11:45:15 -0000
@@ -20,7 +20,7 @@
 #include <unistd.h>
 
 
-char *
+int
 __getgroups_chk (int size, __gid_t list[], size_t listlen)
 {
   if (__builtin_expect (size * sizeof (__gid_t) > listlen, 0))
--- stdio-common/fxprintf.c	20 Jul 2005 17:47:00 -0000	1.2
+++ stdio-common/fxprintf.c	21 Jul 2005 11:45:17 -0000
@@ -22,7 +22,8 @@
 #include <stdarg.h>
 #include <stdio.h>
 #include <wchar.h>
+#include <string.h>
 

 int

-- 
Thorsten Kukuk         http://www.suse.de/~kukuk/      kukuk@suse.de
SUSE LINUX Products GmbH       Maxfeldstr. 5       D-90409 Nuernberg
--------------------------------------------------------------------    
Key fingerprint = A368 676B 5E1B 3E46 CFCE  2D97 F8FD 4E23 56C6 FB4B

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fixes for latest checkins
  2005-07-21 12:55 [PATCH] fixes for latest checkins Thorsten Kukuk
@ 2005-07-21 16:21 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2005-07-21 16:21 UTC (permalink / raw)
  To: Thorsten Kukuk; +Cc: libc-hacker

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

Applied.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-07-21 16:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-21 12:55 [PATCH] fixes for latest checkins Thorsten Kukuk
2005-07-21 16:21 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).