* [PATCH] Use __attribute__ instead of __attribute in installed headers
@ 2005-11-24 17:31 Jakub Jelinek
2005-11-24 18:17 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2005-11-24 17:31 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Glibc hackers
Hi!
<sys/cdefs.h> defines just __attribute__(x) to nothing for crappy
compilers, but not __attribute(x). So I think we should use
the former form.
2005-11-24 Jakub Jelinek <jakub@redhat.com>
[BZ #1920]
* sysdeps/pthread/pthread.h (__pthread_unwind_next): Use
__attribute__ instead of __attribute.
* sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h
(__cleanup_fct_attribute): Likewise.
--- libc/nptl/sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h.jj 2004-09-30 00:50:03.000000000 +0200
+++ libc/nptl/sysdeps/unix/sysv/linux/i386/bits/pthreadtypes.h 2005-11-24 18:23:25.000000000 +0100
@@ -1,4 +1,4 @@
-/* Copyright (C) 2002, 2003, 2004 Free Software Foundation, Inc.
+/* Copyright (C) 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -155,6 +155,6 @@ typedef union
/* Extra attributes for the cleanup functions. */
-#define __cleanup_fct_attribute __attribute ((regparm (1)))
+#define __cleanup_fct_attribute __attribute__ ((regparm (1)))
#endif /* bits/pthreadtypes.h */
--- libc/nptl/sysdeps/pthread/pthread.h.jj 2005-09-12 09:29:08.000000000 +0200
+++ libc/nptl/sysdeps/pthread/pthread.h 2005-11-24 18:19:22.000000000 +0100
@@ -657,9 +657,9 @@ extern void __pthread_unregister_cancel_
/* Internal interface to initiate cleanup. */
extern void __pthread_unwind_next (__pthread_unwind_buf_t *__buf)
- __cleanup_fct_attribute __attribute ((__noreturn__))
+ __cleanup_fct_attribute __attribute__ ((__noreturn__))
# ifndef SHARED
- __attribute ((__weak__))
+ __attribute__ ((__weak__))
# endif
;
#endif
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Use __attribute__ instead of __attribute in installed headers
2005-11-24 17:31 [PATCH] Use __attribute__ instead of __attribute in installed headers Jakub Jelinek
@ 2005-11-24 18:17 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2005-11-24 18:17 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Glibc hackers
Applied.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA â–
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-24 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-24 17:31 [PATCH] Use __attribute__ instead of __attribute in installed headers Jakub Jelinek
2005-11-24 18:17 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).