* [PATCH] Remove nonnull from ctermid decl
@ 2006-01-03 8:23 Jakub Jelinek
2006-01-03 15:57 ` Ulrich Drepper
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2006-01-03 8:23 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Glibc hackers
Hi!
ctermid actually handles NULL argument and is supposed to handle it:
http://www.opengroup.org/onlinepubs/009695399/functions/ctermid.html
"If s is a null pointer, the string shall be generated in an area that
may be static (and therefore may be overwritten by each call), the
address of which shall be returned."
2006-01-03 Jakub Jelinek <jakub@redhat.com>
* posix/unistd.h (ctermid): Remove __nonnull attribute.
--- libc/posix/unistd.h 16 Dec 2005 00:15:19 -0000 1.139
+++ libc/posix/unistd.h 3 Jan 2006 08:17:45 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1991-2002,2003,2004,2005 Free Software Foundation, Inc.
+/* Copyright (C) 1991-2002,2003,2004,2005,2006 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -1075,7 +1075,7 @@ extern void swab (__const void *__restri
It is also found in <stdio.h>. */
#ifdef __USE_XOPEN
/* Return the name of the controlling terminal. */
-extern char *ctermid (char *__s) __THROW __nonnull ((1));
+extern char *ctermid (char *__s) __THROW;
#endif
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove nonnull from ctermid decl
2006-01-03 8:23 [PATCH] Remove nonnull from ctermid decl Jakub Jelinek
@ 2006-01-03 15:57 ` Ulrich Drepper
0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2006-01-03 15:57 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Applied.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-01-03 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-03 8:23 [PATCH] Remove nonnull from ctermid decl Jakub Jelinek
2006-01-03 15:57 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).