* Fix scripts/check-local-headers.sh
@ 2006-01-03 18:21 Andreas Jaeger
2006-01-03 18:56 ` Ulrich Drepper
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Jaeger @ 2006-01-03 18:21 UTC (permalink / raw)
To: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
make check fails with a failure in check-local-headers, the failure
is:
cat /builds/glibc/10.0-nptl/check-local-headers.out
nptl/tst-cancel24.o.d: ../sysdeps/generic/symbol-hacks.h /usr/include/c++/4.0.2/cstdlib \
nptl/tst-cancel24.o.d: /usr/include/c++/4.0.2/x86_64-suse-linux/bits/c++config.h \
nptl/tst-cancel24.o.d: /usr/include/c++/4.0.2/x86_64-suse-linux/bits/os_defines.h \
nptl/tst-cancel24.o.d: ../include/gnu/stubs.h /usr/include/c++/4.0.2/cstddef \
nptl/tst-cancel24.o.d: $(common-objpfx)bits/stdio_lim.h /usr/include/c++/4.0.2/cstdio \
nptl/tst-cancel24.o.d:/usr/include/c++/4.0.2/cstdlib:
nptl/tst-cancel24.o.d:/usr/include/c++/4.0.2/x86_64-suse-linux/bits/c++config.h:
nptl/tst-cancel24.o.d:/usr/include/c++/4.0.2/x86_64-suse-linux/bits/os_defines.h:
nptl/tst-cancel24.o.d:/usr/include/c++/4.0.2/cstddef:
nptl/tst-cancel24.o.d:/usr/include/c++/4.0.2/cstdio:
this is fixed with the appended patch. Ok to commit?
Andreas
2006-01-03 Andreas Jaeger <aj@suse.de>
* scripts/check-local-headers.sh: Allow $includedir/c++.
============================================================
Index: scripts/check-local-headers.sh
--- scripts/check-local-headers.sh 24 Nov 2005 18:13:16 -0000 1.1
+++ scripts/check-local-headers.sh 3 Jan 2006 18:18:59 -0000
@@ -30,7 +30,8 @@ if fgrep "$includedir" */*.d |
fgrep -v "$includedir/asm" |
fgrep -v "$includedir/linux" |
fgrep -v "$includedir/selinux" |
-fgrep -v "$includedir/gd"; then
+fgrep -v "$includedir/gd" |
+fgrep -v "$includedir/c++"; then
# If we found a match something is wrong.
exit 1
fi
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix scripts/check-local-headers.sh
2006-01-03 18:21 Fix scripts/check-local-headers.sh Andreas Jaeger
@ 2006-01-03 18:56 ` Ulrich Drepper
2006-01-06 9:08 ` Andreas Jaeger
0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Drepper @ 2006-01-03 18:56 UTC (permalink / raw)
To: Andreas Jaeger; +Cc: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
Andreas Jaeger wrote:
> this is fixed with the appended patch. Ok to commit?
Yes.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix scripts/check-local-headers.sh
2006-01-03 18:56 ` Ulrich Drepper
@ 2006-01-06 9:08 ` Andreas Jaeger
2006-01-06 15:14 ` Ulrich Drepper
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Jaeger @ 2006-01-06 9:08 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Ulrich Drepper <drepper@redhat.com> writes:
> Andreas Jaeger wrote:
>> this is fixed with the appended patch. Ok to commit?
>
> Yes.
I propose to revert it since tst-cancel24.cc now does not need C++
headers anymore:
2006-01-04 Ulrich Drepper <drepper@redhat.com>
* tst-cancel24.cc: Use C headers instead of C++ headers.
Ok?
I tested this successfully,
Andreas
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix scripts/check-local-headers.sh
2006-01-06 9:08 ` Andreas Jaeger
@ 2006-01-06 15:14 ` Ulrich Drepper
0 siblings, 0 replies; 4+ messages in thread
From: Ulrich Drepper @ 2006-01-06 15:14 UTC (permalink / raw)
To: Andreas Jaeger; +Cc: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
Andreas Jaeger wrote:
> I propose to revert it since tst-cancel24.cc now does not need C++
> headers anymore:
OK.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-01-06 15:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-01-03 18:21 Fix scripts/check-local-headers.sh Andreas Jaeger
2006-01-03 18:56 ` Ulrich Drepper
2006-01-06 9:08 ` Andreas Jaeger
2006-01-06 15:14 ` Ulrich Drepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).