public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Remove unused var in malloc.c
@ 2006-10-11 14:16 Jakub Jelinek
  2006-10-11 16:28 ` Ulrich Drepper
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2006-10-11 14:16 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: Glibc hackers

Hi!

This variable was added back in August, but it doesn't seem
to be used anywhere...

2006-10-11  Jakub Jelinek  <jakub@redhat.com>

	* malloc/malloc.c (_int_malloc): Remove unused any_larger variable.

--- libc/malloc/malloc.c.jj	2006-09-07 18:06:02.000000000 +0200
+++ libc/malloc/malloc.c	2006-10-11 16:12:27.000000000 +0200
@@ -4097,7 +4097,6 @@ _int_malloc(mstate av, size_t bytes)
   for(;;) {
 
     int iters = 0;
-    bool any_larger = false;
     while ( (victim = unsorted_chunks(av)->bk) != unsorted_chunks(av)) {
       bck = victim->bk;
       if (__builtin_expect (victim->size <= 2 * SIZE_SZ, 0)
@@ -4194,8 +4193,6 @@ _int_malloc(mstate av, size_t bytes)
       fwd->bk = victim;
       bck->fd = victim;
 
-      if (size >= nb + MINSIZE)
-	any_larger = true;
 #define MAX_ITERS	10000
       if (++iters >= MAX_ITERS)
 	break;

	Jakub

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unused var in malloc.c
  2006-10-11 14:16 [PATCH] Remove unused var in malloc.c Jakub Jelinek
@ 2006-10-11 16:28 ` Ulrich Drepper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Drepper @ 2006-10-11 16:28 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: Glibc hackers

Applied.  It's easy enough to add the use back but perhaps it's better 
without it.

-- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-10-11 16:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-11 14:16 [PATCH] Remove unused var in malloc.c Jakub Jelinek
2006-10-11 16:28 ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).