public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Steven Munroe <munroesj@us.ibm.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: GNU libc hacker <libc-hacker@sources.redhat.com>,
	Jakub Jelinek <jakub@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] PPC fenv fixes 4th update
Date: Wed, 02 May 2007 14:06:00 -0000	[thread overview]
Message-ID: <46389F1F.9080302@us.ibm.com> (raw)
In-Reply-To: <46384A0D.4070405@redhat.com>

Ulrich Drepper wrote:
> Steven Munroe wrote:
>   
>> +/* This is presently a stub, until it's decided how the kernels should
>> +   support this.  */
>> +
>> +const fenv_t *
>> +__fe_mask_env(void)
>> +{
>> +  __set_errno (ENOSYS);
>> +  return FE_DFL_ENV;
>> +}
>>     
>
> Why are you sending a patch if it's incomplete?  Fix the kernel and then
> send a patch.  Who knows, maybe a completely different solution is needed.
>
>   
The only problem is the comment which should say:

/* This is a generic stub. An OS specific override is required to clear
   the FE0/FE1 bits in the MSR.  MSR update is privileged, so this will
   normally involve a syscall.  */

The real implementations for linux are in
sysdeps/unix/sysv/linux/powerpc/powerpc[32|64]/fe_mask.c

hhhmm should not this be?:
sysdeps/unix/sysv/linux/powerpc/powerpc[32|64]/fpu/fe_mask.c

History bites. Dr. Bergner just copied the existing fe_nomask.c stubs
and overrides. I'll fix it and resubmit.

      reply	other threads:[~2007-05-02 14:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-01 22:08 Steven Munroe
2007-05-02  8:22 ` Ulrich Drepper
2007-05-02 14:06   ` Steven Munroe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46389F1F.9080302@us.ibm.com \
    --to=munroesj@us.ibm.com \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).