public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,Roland McGrath
	<roland@redhat.com>, Jack Howarth <howarth@nitro.med.uc.edu>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix ppc32 ld.so
Date: Fri, 16 May 2003 13:14:00 -0000	[thread overview]
Message-ID: <5.2.1.1.2.20030516151032.03505350@mail.lauterbach.com> (raw)
In-Reply-To: <20030515151608.GX16629@sunsite.ms.mff.cuni.cz>

At 17:16 15.05.2003, Jakub Jelinek wrote:
>Hi!
>
>This is something I cannot understand how it ever worked.
>If there is a reloc overflow on ppc32, _dl_reloc_overflow tries to print the
>name of the symbol. But unless sym is NULL (and thus errsym = refsym) resp.
>equal to refsym, it will print something from the refsym's strtab at index
>sym->st_name, ie. a random string at best, worst case segfault.
>To print sym's name instead of refsym's (though I don't understand why that
>is needed, both sym and refsym ought to always have the same symbol name,
>otherwise symbol lookup is broken) we'd have to pass down sym_map as well,
>but sym_map is not always computed (ATM only if --with-tls).

Hmm, IIRC that was a mere result of try and error. I think I used the first 
version that produced sensible results with the (small) binutils testcases. 
Certainly you have more insight in that relocation code and I believe you 
if you say that it just worked by luck :-).

Franz.

      parent reply	other threads:[~2003-05-16 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-15 15:18 Jakub Jelinek
2003-05-16  4:43 ` Ulrich Drepper
2003-05-16 13:14 ` Franz Sirl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.2.1.1.2.20030516151032.03505350@mail.lauterbach.com \
    --to=franz.sirl-kernel@lauterbach.com \
    --cc=drepper@redhat.com \
    --cc=howarth@nitro.med.uc.edu \
    --cc=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).