public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* Fix warnings in testsuite
@ 2003-06-25 11:09 Andreas Jaeger
  2003-06-25 12:19 ` Jakub Jelinek
  2003-06-25 12:22 ` Andreas Schwab
  0 siblings, 2 replies; 4+ messages in thread
From: Andreas Jaeger @ 2003-06-25 11:09 UTC (permalink / raw)
  To: GNU libc hackers

[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]


The appended patch fixes a number of problems in the testsuite.  I've
commited the patch after testing on x86-64,

Andreas

2003-06-25  Andreas Jaeger  <aj@suse.de>

	* posix/transbug.c: Include <string.h> for memset and strlen
	declarations.

	* stdio-common/tst-sprintf.c: Include <stdlib.h> for free declaration.

	* stdlib/tst-strtod.c (main): Pass long double value.

	* test-skeleton.c: Include <time.h> for nanosleep declaration.

============================================================
Index: posix/transbug.c
--- posix/transbug.c	12 Jun 2003 18:11:16 -0000	1.2
+++ posix/transbug.c	25 Jun 2003 10:56:11 -0000
@@ -5,6 +5,7 @@
 #include <regex.h>
 #include <stdlib.h>
 #include <unistd.h>
+#include <string.h>
 
 /* lowercase chars mapped to uppercase */
 static const char casetable[] = {
============================================================
Index: stdio-common/tst-sprintf.c
--- stdio-common/tst-sprintf.c	27 May 2003 07:39:34 -0000	1.2
+++ stdio-common/tst-sprintf.c	25 Jun 2003 10:56:11 -0000
@@ -1,4 +1,5 @@
 #include <stdio.h>
+#include <stdlib.h>
 #include <string.h>
 
 
============================================================
Index: stdlib/tst-strtod.c
--- stdlib/tst-strtod.c	20 Mar 2003 01:06:11 -0000	1.23
+++ stdlib/tst-strtod.c	25 Jun 2003 10:56:11 -0000
@@ -153,7 +153,7 @@ main (int argc, char ** argv)
   if (strtold (input2, NULL) != +1.000000000116415321826934814453125)
     {
       printf ("input2: %La != %La\n", strtold (input2, NULL),
-	      +1.000000000116415321826934814453125);
+	      +1.000000000116415321826934814453125L);
       status = 1;
     }
 
============================================================
Index: test-skeleton.c
--- test-skeleton.c	25 Jun 2003 07:35:31 -0000	1.25
+++ test-skeleton.c	25 Jun 2003 10:56:11 -0000
@@ -29,6 +29,7 @@
 #include <sys/resource.h>
 #include <sys/wait.h>
 #include <sys/param.h>
+#include <time.h>
 
 /* The test function is normally called `do_test' and it is called
    with argc and argv as the arguments.  We nevertheless provide the

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Fix warnings in testsuite
  2003-06-25 11:09 Fix warnings in testsuite Andreas Jaeger
@ 2003-06-25 12:19 ` Jakub Jelinek
  2003-06-25 15:15   ` Andreas Jaeger
  2003-06-25 12:22 ` Andreas Schwab
  1 sibling, 1 reply; 4+ messages in thread
From: Jakub Jelinek @ 2003-06-25 12:19 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hackers

On Wed, Jun 25, 2003 at 01:04:37PM +0200, Andreas Jaeger wrote:
> --- stdlib/tst-strtod.c	20 Mar 2003 01:06:11 -0000	1.23
> +++ stdlib/tst-strtod.c	25 Jun 2003 10:56:11 -0000
> @@ -153,7 +153,7 @@ main (int argc, char ** argv)
>    if (strtold (input2, NULL) != +1.000000000116415321826934814453125)

Shouldn't this have L suffix as well?				      ^^

	Jakub

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Fix warnings in testsuite
  2003-06-25 11:09 Fix warnings in testsuite Andreas Jaeger
  2003-06-25 12:19 ` Jakub Jelinek
@ 2003-06-25 12:22 ` Andreas Schwab
  1 sibling, 0 replies; 4+ messages in thread
From: Andreas Schwab @ 2003-06-25 12:22 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hackers

Andreas Jaeger <aj@suse.de> writes:

|> Index: stdlib/tst-strtod.c
|> --- stdlib/tst-strtod.c	20 Mar 2003 01:06:11 -0000	1.23
|> +++ stdlib/tst-strtod.c	25 Jun 2003 10:56:11 -0000
|> @@ -153,7 +153,7 @@ main (int argc, char ** argv)
|>    if (strtold (input2, NULL) != +1.000000000116415321826934814453125)

I think you should make that constant long double, too.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Fix warnings in testsuite
  2003-06-25 12:19 ` Jakub Jelinek
@ 2003-06-25 15:15   ` Andreas Jaeger
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Jaeger @ 2003-06-25 15:15 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: GNU libc hackers

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Jakub Jelinek <jakub@redhat.com> writes:

> On Wed, Jun 25, 2003 at 01:04:37PM +0200, Andreas Jaeger wrote:
>> --- stdlib/tst-strtod.c	20 Mar 2003 01:06:11 -0000	1.23
>> +++ stdlib/tst-strtod.c	25 Jun 2003 10:56:11 -0000
>> @@ -153,7 +153,7 @@ main (int argc, char ** argv)
>>    if (strtold (input2, NULL) != +1.000000000116415321826934814453125)
>
> Shouldn't this have L suffix as well?				      ^^

Agreed - I'll do that right now and commit it,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2003-06-25 15:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-25 11:09 Fix warnings in testsuite Andreas Jaeger
2003-06-25 12:19 ` Jakub Jelinek
2003-06-25 15:15   ` Andreas Jaeger
2003-06-25 12:22 ` Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).