* Fix compilation of malloc/arena.c
@ 2004-12-12 16:47 Andreas Schwab
2004-12-12 19:10 ` Ulrich Drepper
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2004-12-12 16:47 UTC (permalink / raw)
To: libc-hacker
2004-12-12 Andreas Schwab <schwab@suse.de>
* malloc/arena.c [USE_ARENAS]: Include <stdbool.h>.
--- malloc/arena.c.~1.13.~ 2004-12-12 17:39:32.000000000 +0100
+++ malloc/arena.c 2004-12-12 17:46:55.167066564 +0100
@@ -539,6 +539,8 @@ thread_atfork_static(ptmalloc_lock_all,
#if USE_ARENAS
+#include <stdbool.h>
+
#if MALLOC_DEBUG > 1
/* Print the complete contents of a single heap to stderr. */
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix compilation of malloc/arena.c
2004-12-12 16:47 Fix compilation of malloc/arena.c Andreas Schwab
@ 2004-12-12 19:10 ` Ulrich Drepper
2004-12-12 19:52 ` Andreas Schwab
0 siblings, 1 reply; 7+ messages in thread
From: Ulrich Drepper @ 2004-12-12 19:10 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
Andreas Schwab wrote:
> 2004-12-12 Andreas Schwab <schwab@suse.de>
>
> * malloc/arena.c [USE_ARENAS]: Include <stdbool.h>.
Which architecture is this? We should make all the internal headers
equal so that these stupid things don't happen again.
--
⧠Ulrich Drepper ⧠Red Hat, Inc. ⧠444 Castro St ⧠Mountain View, CA â
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix compilation of malloc/arena.c
2004-12-12 19:10 ` Ulrich Drepper
@ 2004-12-12 19:52 ` Andreas Schwab
2004-12-12 19:59 ` Ulrich Drepper
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2004-12-12 19:52 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: libc-hacker
Ulrich Drepper <drepper@redhat.com> writes:
> Andreas Schwab wrote:
>> 2004-12-12 Andreas Schwab <schwab@suse.de>
>> * malloc/arena.c [USE_ARENAS]: Include <stdbool.h>.
>
> Which architecture is this?
Any one. You use bool, you need <stdbool.h>. It's as simple as that.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix compilation of malloc/arena.c
2004-12-12 19:52 ` Andreas Schwab
@ 2004-12-12 19:59 ` Ulrich Drepper
2004-12-12 20:43 ` Andreas Schwab
0 siblings, 1 reply; 7+ messages in thread
From: Ulrich Drepper @ 2004-12-12 19:59 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
Andreas Schwab wrote:
> Any one. You use bool, you need <stdbool.h>. It's as simple as that.
Want to be a moron, ey? The archs I use apparently include <stdbool.h>
implicitly some way. This needs to be duplicated for the other archs.
--
⧠Ulrich Drepper ⧠Red Hat, Inc. ⧠444 Castro St ⧠Mountain View, CA â
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix compilation of malloc/arena.c
2004-12-12 19:59 ` Ulrich Drepper
@ 2004-12-12 20:43 ` Andreas Schwab
2004-12-12 20:59 ` Ulrich Drepper
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Schwab @ 2004-12-12 20:43 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: libc-hacker
Ulrich Drepper <drepper@redhat.com> writes:
> Andreas Schwab wrote:
>
>> Any one. You use bool, you need <stdbool.h>. It's as simple as that.
>
> Want to be a moron, ey? The archs I use apparently include <stdbool.h>
> implicitly some way. This needs to be duplicated for the other archs.
No, nothing needs to be duplicated. This is broken for _every_
architecture. Just try building with linuxthreads. Also, the file should
be usable outside glibc.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix compilation of malloc/arena.c
2004-12-12 20:43 ` Andreas Schwab
@ 2004-12-12 20:59 ` Ulrich Drepper
2004-12-12 21:23 ` Andreas Schwab
0 siblings, 1 reply; 7+ messages in thread
From: Ulrich Drepper @ 2004-12-12 20:59 UTC (permalink / raw)
To: Andreas Schwab; +Cc: libc-hacker
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
Andreas Schwab wrote:
> Also, the file should be usable outside glibc.
No, we are far beyond that. This is a customized version.
--
⧠Ulrich Drepper ⧠Red Hat, Inc. ⧠444 Castro St ⧠Mountain View, CA â
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Fix compilation of malloc/arena.c
2004-12-12 20:59 ` Ulrich Drepper
@ 2004-12-12 21:23 ` Andreas Schwab
0 siblings, 0 replies; 7+ messages in thread
From: Andreas Schwab @ 2004-12-12 21:23 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: libc-hacker
Ulrich Drepper <drepper@redhat.com> writes:
> Andreas Schwab wrote:
>> Also, the file should be usable outside glibc.
>
> No, we are far beyond that. This is a customized version.
Then we should rip out all #ifdef _LIBC.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2004-12-12 21:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-12-12 16:47 Fix compilation of malloc/arena.c Andreas Schwab
2004-12-12 19:10 ` Ulrich Drepper
2004-12-12 19:52 ` Andreas Schwab
2004-12-12 19:59 ` Ulrich Drepper
2004-12-12 20:43 ` Andreas Schwab
2004-12-12 20:59 ` Ulrich Drepper
2004-12-12 21:23 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).