* One more gconv_simple lcast patch
@ 2004-02-21 14:13 Andreas Jaeger
2004-02-21 18:15 ` Ulrich Drepper
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Jaeger @ 2004-02-21 14:13 UTC (permalink / raw)
To: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
I missed this in my last patch set. Ok to commit?
Andreas
2004-02-21 Andreas Jaeger <aj@suse.de>
* iconv/gconv_simple.c (internal_ucs4le_loop): Remove cast used as
lvalue.
============================================================
Index: iconv/gconv_simple.c
--- iconv/gconv_simple.c 7 Feb 2004 16:27:50 -0000 1.61
+++ iconv/gconv_simple.c 21 Feb 2004 14:13:06 -0000
@@ -453,9 +453,11 @@ internal_ucs4le_loop (struct __gconv_ste
#if __BYTE_ORDER == __BIG_ENDIAN
/* Sigh, we have to do some real work. */
size_t cnt;
+ uint32_t *outptr32 = (uint32_t *) outptr;
for (cnt = 0; cnt < n_convert; ++cnt, inptr += 4)
- *((uint32_t *) outptr)++ = bswap_32 (*(const uint32_t *) inptr);
+ *outptr32++ = bswap_32 (*(const uint32_t *) inptr);
+ outptr = (unsigned char *) outptr32;
*inptrp = inptr;
*outptrp = outptr;
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: One more gconv_simple lcast patch
2004-02-21 14:13 One more gconv_simple lcast patch Andreas Jaeger
@ 2004-02-21 18:15 ` Ulrich Drepper
2004-02-21 18:23 ` Andreas Jaeger
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Drepper @ 2004-02-21 18:15 UTC (permalink / raw)
To: Andreas Jaeger; +Cc: Glibc hackers
Andreas Jaeger wrote:
> for (cnt = 0; cnt < n_convert; ++cnt, inptr += 4)
> - *((uint32_t *) outptr)++ = bswap_32 (*(const uint32_t *) inptr);
> + *outptr32++ = bswap_32 (*(const uint32_t *) inptr);
> + outptr = (unsigned char *) outptr32;
>
> *inptrp = inptr;
> *outptrp = outptr;
Why the second added line? Just do it in the assignment to *outptrp.
--
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA â–
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: One more gconv_simple lcast patch
2004-02-21 18:15 ` Ulrich Drepper
@ 2004-02-21 18:23 ` Andreas Jaeger
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Jaeger @ 2004-02-21 18:23 UTC (permalink / raw)
To: Ulrich Drepper; +Cc: Glibc hackers
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
Ulrich Drepper <drepper@redhat.com> writes:
> Andreas Jaeger wrote:
>
>> for (cnt = 0; cnt < n_convert; ++cnt, inptr += 4)
>> - *((uint32_t *) outptr)++ = bswap_32 (*(const uint32_t *) inptr);
>> + *outptr32++ = bswap_32 (*(const uint32_t *) inptr);
>> + outptr = (unsigned char *) outptr32;
>>
>> *inptrp = inptr;
>> *outptrp = outptr;
>
> Why the second added line? Just do it in the assignment to *outptrp.
Ok, will do...
Andreas
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-21 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-21 14:13 One more gconv_simple lcast patch Andreas Jaeger
2004-02-21 18:15 ` Ulrich Drepper
2004-02-21 18:23 ` Andreas Jaeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).