From: Andreas Jaeger <aj@suse.de>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [BZ #2078, 2079] Fix some wide functions
Date: Sun, 15 Jan 2006 17:44:00 -0000 [thread overview]
Message-ID: <m3hd85mlnn.fsf@gromit.moeb> (raw)
In-Reply-To: <43CA894B.7000903@redhat.com> (Ulrich Drepper's message of "Sun, 15 Jan 2006 09:41:31 -0800")
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
Ulrich Drepper <drepper@redhat.com> writes:
> Andreas Jaeger wrote:
>> Index: libio/wfileops.c
>> --- libio/wfileops.c 14 Jan 2004 18:40:03 -0000 1.29
>> +++ libio/wfileops.c 15 Jan 2006 16:08:16 -0000
>> @@ -1,4 +1,4 @@
>> -/* Copyright (C) 1993,1995,1997-2003,2004 Free Software Foundation, Inc.
>> +/* Copyright (C) 1993,1995,1997-2003,2004, 2006 Free Software Foundation, Inc.
>> This file is part of the GNU C Library.
>> Written by Ulrich Drepper <drepper@cygnus.com>.
>> Based on the single byte version by Per Bothner <bothner@cygnus.com>.
>> @@ -69,7 +69,7 @@ _IO_wdo_write (fp, data, to_do)
>> {
>> if (_IO_new_do_write (fp, fp->_IO_write_base,
>> fp->_IO_write_ptr - fp->_IO_write_base) == EOF)
>> - return EOF;
>> + return WEOF;
>
> As far as fixing this specific kind of mistake, the patch is fine. But
> there is something fishy in the use of _IO_wdo_write.
Will you take care of this, please? I'll commit my patch now,
Andreas
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj/
SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
prev parent reply other threads:[~2006-01-15 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 16:28 Andreas Jaeger
2006-01-15 17:40 ` Ulrich Drepper
2006-01-15 17:44 ` Andreas Jaeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hd85mlnn.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=drepper@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).