Warning removal

Warning removal

[Andreas Jaeger]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]


This patch gets rid of GCC 3.4's warning:
../sysdeps/ieee754/dbl-64/e_pow.c:49: warning: conflicting types for built-in function 'log2'

Ok to commit?

Andreas

2004-01-22  Andreas Jaeger  <aj@suse.de>

	* sysdeps/ieee754/dbl-64/e_pow.c (log2): Rename to log2x to avoid
	warnings for builtin function log2.


[-- Attachment #1.2: libc-diff --]
[-- Type: text/plain, Size: 1780 bytes --]

============================================================
Index: sysdeps/ieee754/dbl-64/e_pow.c
--- sysdeps/ieee754/dbl-64/e_pow.c	26 Aug 2002 22:40:36 -0000	1.12
+++ sysdeps/ieee754/dbl-64/e_pow.c	22 Jan 2004 10:36:04 -0000
@@ -1,7 +1,7 @@
 /*
  * IBM Accurate Mathematical Library
  * written by International Business Machines Corp.
- * Copyright (C) 2001, 2002 Free Software Foundation
+ * Copyright (C) 2001, 2002, 2004 Free Software Foundation
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU Lesser General Public License as published by
@@ -46,7 +46,7 @@
 
 double __exp1(double x, double xx, double error);
 static double log1(double x, double *delta, double *error);
-static double log2(double x, double *delta, double *error);
+static double log2x(double x, double *delta, double *error);
 double __slowpow(double x, double y,double z);
 static double power1(double x, double y);
 static int checkint(double x);
@@ -159,7 +159,7 @@ double __ieee754_pow(double x, double y)
 /**************************************************************************/
 static double power1(double x, double y) {
   double z,a,aa,error, t,a1,a2,y1,y2;
-  z = log2(x,&aa,&error);
+  z = log2x(x,&aa,&error);
   t = y*134217729.0;
   y1 = t - (t-y);
   y2 = y - y1;
@@ -272,7 +272,7 @@ static double log1(double x, double *del
 /* Computing log(x)(x is left argument).The result is return double + delta.*/
 /* The result is bounded by error (right argument)                           */
 /****************************************************************************/
-static double log2(double x, double *delta, double *error) {
+static double log2x(double x, double *delta, double *error) {
   int i,j,m;
 #if 0
   int n;

[-- Attachment #1.3: Type: text/plain, Size: 190 bytes --]


-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Warning removal

[Roland McGrath]

> 
> This patch gets rid of GCC 3.4's warning:
> ../sysdeps/ieee754/dbl-64/e_pow.c:49: warning: conflicting types for built-in function 'log2'
> 
> Ok to commit?

That looks fine to me, though a less obscure name line "my_log2" might
be a littler better.

Re: Warning removal

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Roland McGrath <roland@redhat.com> writes:

>> 
>> This patch gets rid of GCC 3.4's warning:
>> ../sysdeps/ieee754/dbl-64/e_pow.c:49: warning: conflicting types for built-in function 'log2'
>> 
>> Ok to commit?
>
> That looks fine to me, though a less obscure name line "my_log2" might
> be a littler better.

Ok, changed it as suggested and will commit now,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]