* Contribution Checklist - ChangeLog
@ 2020-08-19 15:48 Max Gautier
2020-08-19 15:56 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Max Gautier @ 2020-08-19 15:48 UTC (permalink / raw)
To: libc-help
Hi
I'm writing a contribution to the glibc, (new iconv module) and I don't
completely understand the ChangeLog section of the contribution
checklist [1]. I'm not sure if I should make a new ChangeLog file at the
root directory, describe my changes in NEWS or something else... Section
4 of the contribution checklist state that there should be one ChangeLog
file at the root of the git tree, but I don't find it (in branch
master). Could someone explain what is the correct procedure ?
Thanks a lot
Max Gautier
[1]: https://sourceware.org/glibc/wiki/Contribution%20checklist#GNUChangeLog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Contribution Checklist - ChangeLog
2020-08-19 15:48 Contribution Checklist - ChangeLog Max Gautier
@ 2020-08-19 15:56 ` Florian Weimer
2020-08-19 16:22 ` Max Gautier
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2020-08-19 15:56 UTC (permalink / raw)
To: Max Gautier via Libc-help; +Cc: Max Gautier
* Max Gautier via Libc-help:
> I'm writing a contribution to the glibc, (new iconv module) and I don't
> completely understand the ChangeLog section of the contribution
> checklist [1]. I'm not sure if I should make a new ChangeLog file at the
> root directory, describe my changes in NEWS or something else... Section
> 4 of the contribution checklist state that there should be one ChangeLog
> file at the root of the git tree, but I don't find it (in branch
> master). Could someone explain what is the correct procedure ?
You don't have to write a ChangeLog entry anymore, so you can ignore
this part of the contribution checklist.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Contribution Checklist - ChangeLog
2020-08-19 15:56 ` Florian Weimer
@ 2020-08-19 16:22 ` Max Gautier
2020-08-19 20:30 ` Carlos O'Donell
0 siblings, 1 reply; 6+ messages in thread
From: Max Gautier @ 2020-08-19 16:22 UTC (permalink / raw)
To: Libc-help
Ok, thanks then.
It might be worth it to update the wiki ? It seems the page is immutable
for me at least
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Contribution Checklist - ChangeLog
2020-08-19 16:22 ` Max Gautier
@ 2020-08-19 20:30 ` Carlos O'Donell
2020-08-20 3:30 ` Siddhesh Poyarekar
0 siblings, 1 reply; 6+ messages in thread
From: Carlos O'Donell @ 2020-08-19 20:30 UTC (permalink / raw)
To: Max Gautier, libc-help, Siddhesh Poyarekar
On 8/19/20 12:22 PM, Max Gautier via Libc-help wrote:
> Ok, thanks then.
>
> It might be worth it to update the wiki ? It seems the page is immutable
> for me at least
>
Absolutely. I thought we'd done that when we migrated to using the
automatically generated ChangeLogs.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Contribution Checklist - ChangeLog
2020-08-19 20:30 ` Carlos O'Donell
@ 2020-08-20 3:30 ` Siddhesh Poyarekar
2020-08-20 7:56 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: Siddhesh Poyarekar @ 2020-08-20 3:30 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: Max Gautier, libc-help, Siddhesh Poyarekar
On Thu, 20 Aug 2020 at 02:08, Carlos O'Donell via Libc-help
<libc-help@sourceware.org> wrote:
> Absolutely. I thought we'd done that when we migrated to using the
> automatically generated ChangeLogs.
Sorry I think I missed updating the contribution checklist. I am
inclined towards removing all mention of the ChangeLog in the
checklist and add a last point about needing ChangeLog entries for
patches to stable branches older than 2.31. Does that sound
reasonable?
Siddhesh
--
http://siddhesh.in
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Contribution Checklist - ChangeLog
2020-08-20 3:30 ` Siddhesh Poyarekar
@ 2020-08-20 7:56 ` Florian Weimer
0 siblings, 0 replies; 6+ messages in thread
From: Florian Weimer @ 2020-08-20 7:56 UTC (permalink / raw)
To: Siddhesh Poyarekar via Libc-help
Cc: Carlos O'Donell, Siddhesh Poyarekar, Siddhesh Poyarekar, Max Gautier
* Siddhesh Poyarekar via Libc-help:
> On Thu, 20 Aug 2020 at 02:08, Carlos O'Donell via Libc-help
> <libc-help@sourceware.org> wrote:
>> Absolutely. I thought we'd done that when we migrated to using the
>> automatically generated ChangeLogs.
>
> Sorry I think I missed updating the contribution checklist. I am
> inclined towards removing all mention of the ChangeLog in the
> checklist and add a last point about needing ChangeLog entries for
> patches to stable branches older than 2.31. Does that sound
> reasonable?
I don't think it makes sense to treat older stable branches
differently. Either all of them need ChangeLogs, or none of them do.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-20 7:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 15:48 Contribution Checklist - ChangeLog Max Gautier
2020-08-19 15:56 ` Florian Weimer
2020-08-19 16:22 ` Max Gautier
2020-08-19 20:30 ` Carlos O'Donell
2020-08-20 3:30 ` Siddhesh Poyarekar
2020-08-20 7:56 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).