Initial review request of a warning patch in math.h

Initial review request of a warning patch in math.h

[Krystian Kuźniarek]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Hi,

I found a very trivial warning about a training comma at the end of
enumerator list. This generates a warning both on GCC and Clang since a
trailing comma thing is a C99/C++11 extension.

Enclosed you'll find a one-liner patch. Please let me know if this has any
chance of being submitted.

Best regards,
Krystian Kuźniarek

[-- Attachment #2: math_comma_warning.diff --]
[-- Type: text/x-patch, Size: 287 bytes --]

diff --git a/math/math.h b/math/math.h
index e48860e391..5ac4cfc302 100644
--- a/math/math.h
+++ b/math/math.h
@@ -250,7 +250,7 @@ enum
       FP_INT_TONEARESTFROMZERO,
     FP_INT_TONEAREST =
 # define FP_INT_TONEAREST 4
-      FP_INT_TONEAREST,
+      FP_INT_TONEAREST
   };
 #endif
 

Re: Initial review request of a warning patch in math.h

[Florian Weimer]

* Krystian Kuźniarek via Libc-help:

> I found a very trivial warning about a training comma at the end of
> enumerator list. This generates a warning both on GCC and Clang since a
> trailing comma thing is a C99/C++11 extension.
>
> Enclosed you'll find a one-liner patch. Please let me know if this has any
> chance of being submitted.

I think the question is why one would use a C2X extension in a pre-C99
mode.  As far as I can tell, this is a rather odd combination.

Thanks,
Florian