public inbox for libc-help@sourceware.org
 help / color / mirror / Atom feed
From: "John McCabe" <john@mccabe.org.uk>
To: libc-help@sourceware.org
Subject: New patch help...
Date: Tue, 19 Jan 2021 18:40:44 +0000	[thread overview]
Message-ID: <em8a4fbe55-ad8d-4c93-84ae-61a747142492@kt-lap20-jm01> (raw)

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Apologies if I just appear a bit dim, but I've just reported a bug on 
the glibc documentation, so have tried to follow the instructions to 
also fix it, as it's relatively easy. To be honest though, I've not used 
git in much depth really, so I'm slightly lost and wonder if you could 
advise me.

Attached is the patch I've generated, based on master; I feel that there 
is probably something missing but I'm not totally sure. If you could let 
me know, that would be useful.

Also the "new committer" bit mentions about FSF copyright assignment; as 
far as I remember, I signed something when I was sending patches into 
GNU Emacs - would that still be valid?

Many thanks.
John

[-- Attachment #2: 0001-manual-Correct-argument-order-in-mount-examples-bug-.patch --]
[-- Type: application/octet-stream, Size: 862 bytes --]

From 29171f18cbc325000a84d585ad298ba78eb9941b Mon Sep 17 00:00:00 2001
From: John McCabe <jmccabe@kirintec.com>
Date: Tue, 19 Jan 2021 18:25:25 +0000
Subject: [PATCH] manual: Correct argument order in mount examples (bug 27207)
To: libc-alpha@sourceware.org

---
 manual/sysinfo.texi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/manual/sysinfo.texi b/manual/sysinfo.texi
index 4ca4555443..8a10428774 100644
--- a/manual/sysinfo.texi
+++ b/manual/sysinfo.texi
@@ -954,9 +954,9 @@ Example:
 @group
 #include <sys/mount.h>
 
-mount("/dev/hdb", "/cdrom", MS_MGC_VAL | MS_RDONLY | MS_NOSUID, "");
+mount("/dev/hdb", "/cdrom", "", MS_MGC_VAL | MS_RDONLY | MS_NOSUID);
 
-mount("/dev/hda2", "/mnt", MS_MGC_VAL | MS_REMOUNT, "");
+mount("/dev/hda2", "/mnt", "", MS_MGC_VAL | MS_REMOUNT);
 
 @end group
 @end smallexample
-- 
2.30.0.windows.2


             reply	other threads:[~2021-01-19 18:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 18:40 John McCabe [this message]
2021-01-21 15:37 ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=em8a4fbe55-ad8d-4c93-84ae-61a747142492@kt-lap20-jm01 \
    --to=john@mccabe.org.uk \
    --cc=libc-help@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).