public inbox for libc-locales@sourceware.org
 help / color / mirror / Atom feed
* sr_ME locale country_isbn and int_prefix fix
@ 2013-05-19 15:51 Jakub Bogusz
       [not found] ` <CAHdAataN0GXw5yXxrAR_J+eVckFiM0TDSmKsiaStq7yJ-mj=-w@mail.gmail.com>
  0 siblings, 1 reply; 14+ messages in thread
From: Jakub Bogusz @ 2013-05-19 15:51 UTC (permalink / raw)
  To: libc-locales

[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

Hello,

It appears that sr_ME locale still inherits country_isbn and (LC_TELEPHONE)
int_prefix codes from Serbian locale (formerly sr_CS, now sr_RS), while
Montenegro now uses separate values:

ISBN: 9940
int_prefix: +382

Some referencess:
http://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups
http://en.wikipedia.org/wiki/Country_codes_of_Serbia#Country_calling_code

The attached patch updates these identifiers.


-- 
Jakub Bogusz    http://qboosh.pl/

[-- Attachment #2: sr_ME-fix.patch --]
[-- Type: text/plain, Size: 843 bytes --]

--- glibc-2.17/localedata/locales/sr_ME.orig	2012-12-25 04:02:13.000000000 +0100
+++ glibc-2.17/localedata/locales/sr_ME	2013-01-04 15:59:24.058148312 +0100
@@ -149,7 +149,7 @@
 country_name  "<U0426><U0440><U043D><U0430><U0020><U0413><U043E><U0440><U0430>"
 country_num   499
 country_car   "<U004D><U004E><U0045>"
-country_isbn  "<U0038><U0036>"
+country_isbn  "<U0039><U0039><U0034><U0030>"
 lang_name     "<U0441><U0440><U043F><U0441><U043A><U0438>"
 lang_term     "<U0073><U0072><U0070>"
 lang_lib      "<U0073><U0063><U0063>"
@@ -157,7 +157,11 @@
 END LC_ADDRESS
 
 LC_TELEPHONE
-copy "sr_RS"
+tel_int_fmt   "<U002B><U0025><U0063><U0020><U0025><U0061><U0020><U0025>/
+<U006C>"
+tel_dom_fmt   "<U0025><U0041><U0020><U0025><U006C>"
+int_prefix    "<U0033><U0038><U0032>"
+int_select    "<U0030><U0030>"
 END LC_TELEPHONE
 
 LC_MEASUREMENT

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-27  6:33         ` LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix] Jakub Bogusz
@ 2013-08-26 21:26           ` Chris Leonard
  2013-08-26 22:35             ` Chris Leonard
  2013-08-27 14:04             ` Jakub Bogusz
  2013-09-01 12:07           ` Chris Leonard
  1 sibling, 2 replies; 14+ messages in thread
From: Chris Leonard @ 2013-08-26 21:26 UTC (permalink / raw)
  To: Jakub Bogusz; +Cc: Carlos O'Donell, libc-alpha, libc-locales

I looked at your first patch

Fill in country_{car,isbn} for aa_ET.

--- libc.orig/localedata/locales/aa_ET 2003-11-04 05:53:19.000000000 +0100
+++ libc/localedata/locales/aa_ET 2004-11-10 02:36:38.000000000 +0100
@@ -109,8 +109,8 @@
 country_ab2   "<U0045><U0054>"
 country_ab3   "<U0045><U0054><U0048>"
 country_num   231   % 210 found in at least one ISO 3166 doc
-% country_car   unknown
-% country_isbn  unknown, Need ISO 2108
+country_car   "<U0045><U0054><U0048>"
+country_isbn  "<U0039><U0039><U0039><U0034><U0034>"
 lang_name     "<U0051><U0061><U0066><U0061><U0072>"
 lang_ab       "<U0061><U0061>"
 lang_term     "<U0061><U0061><U0072>"


I am not 100% sure, but I was under the impression from looking at
other locales that country_isbn was a simple numeric value and not
quoted and converted into Unicode points.

Am I correct in this?

cjl


On Mon, Aug 26, 2013 at 2:56 PM, Jakub Bogusz <qboosh@pld-linux.org> wrote:
> On Thu, Jun 06, 2013 at 09:53:22AM -0400, Carlos O'Donell wrote:
>> On 06/06/2013 04:14 AM, Jakub Bogusz wrote:
>> > On Wed, May 22, 2013 at 11:13:03PM -0400, Carlos O'Donell wrote:
>> >> On 05/22/2013 10:41 PM, Chris Leonard wrote:
>> >>> This will probably be ignored on libc-locales, forwarding to
>> >>> libc-alpha for consideration.
>> >>
>> >> Chris,
>> >>
>> >> I saw this on libc-locales, but I'm up to my ears in other things.
>> >>
>> >> Are you able to review it and check it in? :-)
>> >>
>> >> If we are going to grow as a community we need to delegate work.
>> >
>> > Any progress on this patch?
>>
>> Not yet.
>>
>> Added it to the pending review list:
>> http://sourceware.org/glibc/wiki/Pending%20Reviews
>>
>> > There probably should be also Latin version of sr_ME locale, as
>> > Latin is widely used in Montenegro (when I visited this country last
>> > year, it appeared to me that Latin is far more common than Cyrillic,
>> > but I don't have any official evidence for it).
>> >
>> > BTW: In PLD we have many country_car, country_isbn and similar fixes
>> > for other glibc locales. I could isolate some patches - what is the
>> > preferred way: one patch will all changes, many individual patches for
>> > each locale, or some blocks of them?
>>
>> Many individual patches for each locale is the easiest way to review them.
>
> I started the work to split the big patch, verify and update each change
> (few parts required it).
> Parts already processed can be seen at:
> http://qboosh.pl/glibc-locale-fixes/
> (glibc-locale_fixes.patch contains the remaining, unverified parts)
>
>
> Regards,
>
> --
> Jakub Bogusz    http://qboosh.pl/

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-26 21:26           ` Chris Leonard
@ 2013-08-26 22:35             ` Chris Leonard
  2013-08-27 14:04             ` Jakub Bogusz
  1 sibling, 0 replies; 14+ messages in thread
From: Chris Leonard @ 2013-08-26 22:35 UTC (permalink / raw)
  To: Jakub Bogusz; +Cc: Carlos O'Donell, libc-alpha, libc-locales

In addition, it would really help the review of these patches if you
commented the country_car entries to contain the non-encoded value

e.g.
> +% ETH
> +country_car   "<U0045><U0054><U0048>"

It would make it much easier to confirm these patches against

http://en.wikipedia.org/wiki/List_of_international_license_plate_codes

cjl


On Mon, Aug 26, 2013 at 5:25 PM, Chris Leonard <cjlhomeaddress@gmail.com> wrote:
> I looked at your first patch
>
> Fill in country_{car,isbn} for aa_ET.
>
> --- libc.orig/localedata/locales/aa_ET 2003-11-04 05:53:19.000000000 +0100
> +++ libc/localedata/locales/aa_ET 2004-11-10 02:36:38.000000000 +0100
> @@ -109,8 +109,8 @@
>  country_ab2   "<U0045><U0054>"
>  country_ab3   "<U0045><U0054><U0048>"
>  country_num   231   % 210 found in at least one ISO 3166 doc
> -% country_car   unknown
> -% country_isbn  unknown, Need ISO 2108
> +country_car   "<U0045><U0054><U0048>"
> +country_isbn  "<U0039><U0039><U0039><U0034><U0034>"
>  lang_name     "<U0051><U0061><U0066><U0061><U0072>"
>  lang_ab       "<U0061><U0061>"
>  lang_term     "<U0061><U0061><U0072>"
>
>
> I am not 100% sure, but I was under the impression from looking at
> other locales that country_isbn was a simple numeric value and not
> quoted and converted into Unicode points.
>
> Am I correct in this?
>
> cjl
>
>
> On Mon, Aug 26, 2013 at 2:56 PM, Jakub Bogusz <qboosh@pld-linux.org> wrote:
>> On Thu, Jun 06, 2013 at 09:53:22AM -0400, Carlos O'Donell wrote:
>>> On 06/06/2013 04:14 AM, Jakub Bogusz wrote:
>>> > On Wed, May 22, 2013 at 11:13:03PM -0400, Carlos O'Donell wrote:
>>> >> On 05/22/2013 10:41 PM, Chris Leonard wrote:
>>> >>> This will probably be ignored on libc-locales, forwarding to
>>> >>> libc-alpha for consideration.
>>> >>
>>> >> Chris,
>>> >>
>>> >> I saw this on libc-locales, but I'm up to my ears in other things.
>>> >>
>>> >> Are you able to review it and check it in? :-)
>>> >>
>>> >> If we are going to grow as a community we need to delegate work.
>>> >
>>> > Any progress on this patch?
>>>
>>> Not yet.
>>>
>>> Added it to the pending review list:
>>> http://sourceware.org/glibc/wiki/Pending%20Reviews
>>>
>>> > There probably should be also Latin version of sr_ME locale, as
>>> > Latin is widely used in Montenegro (when I visited this country last
>>> > year, it appeared to me that Latin is far more common than Cyrillic,
>>> > but I don't have any official evidence for it).
>>> >
>>> > BTW: In PLD we have many country_car, country_isbn and similar fixes
>>> > for other glibc locales. I could isolate some patches - what is the
>>> > preferred way: one patch will all changes, many individual patches for
>>> > each locale, or some blocks of them?
>>>
>>> Many individual patches for each locale is the easiest way to review them.
>>
>> I started the work to split the big patch, verify and update each change
>> (few parts required it).
>> Parts already processed can be seen at:
>> http://qboosh.pl/glibc-locale-fixes/
>> (glibc-locale_fixes.patch contains the remaining, unverified parts)
>>
>>
>> Regards,
>>
>> --
>> Jakub Bogusz    http://qboosh.pl/

^ permalink raw reply	[flat|nested] 14+ messages in thread

* LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
       [not found]       ` <51B09452.8040009@redhat.com>
@ 2013-08-27  6:33         ` Jakub Bogusz
  2013-08-26 21:26           ` Chris Leonard
  2013-09-01 12:07           ` Chris Leonard
  0 siblings, 2 replies; 14+ messages in thread
From: Jakub Bogusz @ 2013-08-27  6:33 UTC (permalink / raw)
  To: Carlos O'Donell; +Cc: Chris Leonard, libc-alpha, libc-locales

On Thu, Jun 06, 2013 at 09:53:22AM -0400, Carlos O'Donell wrote:
> On 06/06/2013 04:14 AM, Jakub Bogusz wrote:
> > On Wed, May 22, 2013 at 11:13:03PM -0400, Carlos O'Donell wrote:
> >> On 05/22/2013 10:41 PM, Chris Leonard wrote:
> >>> This will probably be ignored on libc-locales, forwarding to
> >>> libc-alpha for consideration.
> >>
> >> Chris,
> >>
> >> I saw this on libc-locales, but I'm up to my ears in other things.
> >>
> >> Are you able to review it and check it in? :-)
> >>
> >> If we are going to grow as a community we need to delegate work.
> > 
> > Any progress on this patch?
> 
> Not yet. 
> 
> Added it to the pending review list:
> http://sourceware.org/glibc/wiki/Pending%20Reviews
> 
> > There probably should be also Latin version of sr_ME locale, as
> > Latin is widely used in Montenegro (when I visited this country last
> > year, it appeared to me that Latin is far more common than Cyrillic,
> > but I don't have any official evidence for it).
> > 
> > BTW: In PLD we have many country_car, country_isbn and similar fixes
> > for other glibc locales. I could isolate some patches - what is the
> > preferred way: one patch will all changes, many individual patches for
> > each locale, or some blocks of them?
> 
> Many individual patches for each locale is the easiest way to review them.

I started the work to split the big patch, verify and update each change
(few parts required it).
Parts already processed can be seen at:
http://qboosh.pl/glibc-locale-fixes/
(glibc-locale_fixes.patch contains the remaining, unverified parts)


Regards,

-- 
Jakub Bogusz    http://qboosh.pl/

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-26 21:26           ` Chris Leonard
  2013-08-26 22:35             ` Chris Leonard
@ 2013-08-27 14:04             ` Jakub Bogusz
  2013-08-27 22:33               ` Chris Leonard
  1 sibling, 1 reply; 14+ messages in thread
From: Jakub Bogusz @ 2013-08-27 14:04 UTC (permalink / raw)
  To: Chris Leonard; +Cc: libc-alpha, libc-locales

On Mon, Aug 26, 2013 at 05:25:31PM -0400, Chris Leonard wrote:
> I looked at your first patch
> 
> Fill in country_{car,isbn} for aa_ET.
> 
> --- libc.orig/localedata/locales/aa_ET 2003-11-04 05:53:19.000000000 +0100
> +++ libc/localedata/locales/aa_ET 2004-11-10 02:36:38.000000000 +0100
> @@ -109,8 +109,8 @@
>  country_ab2   "<U0045><U0054>"
>  country_ab3   "<U0045><U0054><U0048>"
>  country_num   231   % 210 found in at least one ISO 3166 doc
> -% country_car   unknown
> -% country_isbn  unknown, Need ISO 2108
> +country_car   "<U0045><U0054><U0048>"
> +country_isbn  "<U0039><U0039><U0039><U0034><U0034>"
>  lang_name     "<U0051><U0061><U0066><U0061><U0072>"
>  lang_ab       "<U0061><U0061>"
>  lang_term     "<U0061><U0061><U0072>"
> 
> 
> I am not 100% sure, but I was under the impression from looking at
> other locales that country_isbn was a simple numeric value and not
> quoted and converted into Unicode points.
> 
> Am I correct in this?

I can't see any consistency in (upstream) glibc.
Among 45 locales containing country_isbn field:
- 23 have numeric value unquoted
- 11 have numeric value in quotes
- 11 have value coded in Unicode points

Also note that some countries have more than one ISBN prefix (there is
single case in upstream glibc: es_CR locale). Such case (I think) cannot
be represented as unquoted numeric value.


-- 
Jakub Bogusz    http://qboosh.pl/

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-27 14:04             ` Jakub Bogusz
@ 2013-08-27 22:33               ` Chris Leonard
  2013-08-28  0:44                 ` keld
  0 siblings, 1 reply; 14+ messages in thread
From: Chris Leonard @ 2013-08-27 22:33 UTC (permalink / raw)
  To: Jakub Bogusz; +Cc: libc-alpha, libc-locales, keld

On Tue, Aug 27, 2013 at 9:58 AM, Jakub Bogusz <jakub@bogusz.priv.pl> wrote:
> On Mon, Aug 26, 2013 at 05:25:31PM -0400, Chris Leonard wrote:
>> I looked at your first patch
>>
>> Fill in country_{car,isbn} for aa_ET.


>> I am not 100% sure, but I was under the impression from looking at
>> other locales that country_isbn was a simple numeric value and not
>> quoted and converted into Unicode points.
>>
>> Am I correct in this?
>
> I can't see any consistency in (upstream) glibc.
> Among 45 locales containing country_isbn field:
> - 23 have numeric value unquoted
> - 11 have numeric value in quotes
> - 11 have value coded in Unicode points
>
> Also note that some countries have more than one ISBN prefix (there is
> single case in upstream glibc: es_CR locale). Such case (I think) cannot
> be represented as unquoted numeric value.

Jakub,

I am sincerely trying to help you land these patches, not just
nit-picking.  I've completed a review of country_car (for example),
whcih mostly looks fine.  When I look at what I think is the same grep
of the locales dir for "country_ISBN", I see similar numbers, but
interpret them differently.

The 20-odd numeric only locales includes numerous European
lang_country pairs, the most heavily scrutinized locales.

The 11 quoted numerics at least suggest that numeric is the way to go,
and they are primarily minority langs in their specificed countries,
locales that receive far less review.

The 11 Unicode converted includes 4 without quotes (making it 7 and 4
and those 4 are all Chinese locales (suggesting the possibility of a
propagating error).

For me the preponderance of evidence favors unquoted numerics  but as
I originally stated, I am not 100% sure.

Obviously "reading tea leaves" to determine the proper format is an
inexact art at  best.  I have previously bemoaned the lack of a
definitive specification for locales and this example points out the
urgent need for one.

I would love to have the input of a locale old-timer like Keld or one
of the developers to make a call on the country_isbn format question
that we can move forward with.  In the meantime, I will continue
looking over the patches other changes with an eye towards speaking in
favor of committing them once questions are resolved.

cjl

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-28  0:44                 ` keld
@ 2013-08-28  0:03                   ` Chris Leonard
  2013-09-01 11:51                     ` Chris Leonard
  2013-09-01 17:55                     ` keld
  0 siblings, 2 replies; 14+ messages in thread
From: Chris Leonard @ 2013-08-28  0:03 UTC (permalink / raw)
  To: keld; +Cc: Jakub Bogusz, libc-alpha, libc-locales

On Tue, Aug 27, 2013 at 7:33 PM,  <keld@keldix.com> wrote:
> There is a newer locale specification available as
> ISO TR 30112, it describes most keywords that we have implemented
> in libc.  Else the old ISO TR 14652 has most info also.
>
> I think it would be useful to have a full description of
> libc - probably based on latest 30112 text.
>
> Best regards
> keld
>


Keld,

Unfortunately, the version I could get my hands on (working draft 3)

http://www.unicode.org/L2/L2011/11097-tr30112-wd3.pdf

only mentions country_isbn in Appendix E and not in section 4.11, so
it does not shed light on the format question.

cjl

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-27 22:33               ` Chris Leonard
@ 2013-08-28  0:44                 ` keld
  2013-08-28  0:03                   ` Chris Leonard
  0 siblings, 1 reply; 14+ messages in thread
From: keld @ 2013-08-28  0:44 UTC (permalink / raw)
  To: Chris Leonard; +Cc: Jakub Bogusz, libc-alpha, libc-locales

There is a newer locale specification available as 
ISO TR 30112, it describes most keywords that we have implemented
in libc.  Else the old ISO TR 14652 has most info also.

I think it would be useful to have a full description of
libc - probably based on latest 30112 text.

Best regards
keld


On Tue, Aug 27, 2013 at 06:32:45PM -0400, Chris Leonard wrote:
> On Tue, Aug 27, 2013 at 9:58 AM, Jakub Bogusz <jakub@bogusz.priv.pl> wrote:
> > On Mon, Aug 26, 2013 at 05:25:31PM -0400, Chris Leonard wrote:
> >> I looked at your first patch
> >>
> >> Fill in country_{car,isbn} for aa_ET.
> 
> 
> >> I am not 100% sure, but I was under the impression from looking at
> >> other locales that country_isbn was a simple numeric value and not
> >> quoted and converted into Unicode points.
> >>
> >> Am I correct in this?
> >
> > I can't see any consistency in (upstream) glibc.
> > Among 45 locales containing country_isbn field:
> > - 23 have numeric value unquoted
> > - 11 have numeric value in quotes
> > - 11 have value coded in Unicode points
> >
> > Also note that some countries have more than one ISBN prefix (there is
> > single case in upstream glibc: es_CR locale). Such case (I think) cannot
> > be represented as unquoted numeric value.
> 
> Jakub,
> 
> I am sincerely trying to help you land these patches, not just
> nit-picking.  I've completed a review of country_car (for example),
> whcih mostly looks fine.  When I look at what I think is the same grep
> of the locales dir for "country_ISBN", I see similar numbers, but
> interpret them differently.
> 
> The 20-odd numeric only locales includes numerous European
> lang_country pairs, the most heavily scrutinized locales.
> 
> The 11 quoted numerics at least suggest that numeric is the way to go,
> and they are primarily minority langs in their specificed countries,
> locales that receive far less review.
> 
> The 11 Unicode converted includes 4 without quotes (making it 7 and 4
> and those 4 are all Chinese locales (suggesting the possibility of a
> propagating error).
> 
> For me the preponderance of evidence favors unquoted numerics  but as
> I originally stated, I am not 100% sure.
> 
> Obviously "reading tea leaves" to determine the proper format is an
> inexact art at  best.  I have previously bemoaned the lack of a
> definitive specification for locales and this example points out the
> urgent need for one.
> 
> I would love to have the input of a locale old-timer like Keld or one
> of the developers to make a call on the country_isbn format question
> that we can move forward with.  In the meantime, I will continue
> looking over the patches other changes with an eye towards speaking in
> favor of committing them once questions are resolved.
> 
> cjl

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-28  0:03                   ` Chris Leonard
@ 2013-09-01 11:51                     ` Chris Leonard
  2013-09-01 15:09                       ` Jakub Bogusz
  2013-09-01 17:16                       ` keld
  2013-09-01 17:55                     ` keld
  1 sibling, 2 replies; 14+ messages in thread
From: Chris Leonard @ 2013-09-01 11:51 UTC (permalink / raw)
  To: keld; +Cc: Jakub Bogusz, libc-alpha, libc-locales

Keld,

We are still at an impasse on the proper format for country_isbn.

Jakub believes that it should be quoted in unicode points, where as I
beiieve it should be a simple numeric.

The specification you cited was not informative on this point,

Can you give us an informed (definitive) answer to this question?

I would very much like ot move Jakub's many patches forward t oreview
and commit, but I need an answer on this question first.


cjl

On Tue, Aug 27, 2013 at 8:02 PM, Chris Leonard <cjlhomeaddress@gmail.com> wrote:
> On Tue, Aug 27, 2013 at 7:33 PM,  <keld@keldix.com> wrote:
>> There is a newer locale specification available as
>> ISO TR 30112, it describes most keywords that we have implemented
>> in libc.  Else the old ISO TR 14652 has most info also.
>>
>> I think it would be useful to have a full description of
>> libc - probably based on latest 30112 text.
>>
>> Best regards
>> keld
>>
>
>
> Keld,
>
> Unfortunately, the version I could get my hands on (working draft 3)
>
> http://www.unicode.org/L2/L2011/11097-tr30112-wd3.pdf
>
> only mentions country_isbn in Appendix E and not in section 4.11, so
> it does not shed light on the format question.
>
> cjl

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-27  6:33         ` LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix] Jakub Bogusz
  2013-08-26 21:26           ` Chris Leonard
@ 2013-09-01 12:07           ` Chris Leonard
  2013-09-02  9:06             ` Jakub Bogusz
  1 sibling, 1 reply; 14+ messages in thread
From: Chris Leonard @ 2013-09-01 12:07 UTC (permalink / raw)
  To: Jakub Bogusz; +Cc: Carlos O'Donell, libc-alpha, libc-locales

On Mon, Aug 26, 2013 at 2:56 PM, Jakub Bogusz <qboosh@pld-linux.org> wrote:

> I started the work to split the big patch, verify and update each change
> (few parts required it).
> Parts already processed can be seen at:
> http://qboosh.pl/glibc-locale-fixes/
> (glibc-locale_fixes.patch contains the remaining, unverified parts)

Jakub,

In order to assist with reviewing these many patches, would you be
willing to include simple text comment lines immediately prior to the
entries in Unicode points to simplify the review process.

For example, instead of

Fill in country_{car,isbn} for aa_ET.

+country_car   "<U0045><U0054><U0048>"

could you instead include

+ %ETH
+country_car   "<U0045><U0054><U0048>"

And the same for language name, etc. where they appear.  It would
vastly simplfy the review process and speed acceptance of your patches
once we have the country_isbn question resolved.

cjl

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-09-01 11:51                     ` Chris Leonard
@ 2013-09-01 15:09                       ` Jakub Bogusz
  2013-09-01 17:16                       ` keld
  1 sibling, 0 replies; 14+ messages in thread
From: Jakub Bogusz @ 2013-09-01 15:09 UTC (permalink / raw)
  To: Chris Leonard; +Cc: keld, libc-alpha, libc-locales

On Sun, Sep 01, 2013 at 07:50:28AM -0400, Chris Leonard wrote:
> Keld,
> 
> We are still at an impasse on the proper format for country_isbn.
> 
> Jakub believes that it should be quoted in unicode points, where as I
> beiieve it should be a simple numeric.

Just for the comment - I didn't say I think they should be quoted in
unicode points. I wrote that the three forms coexist in existing
locales.

As I investigated now, from the technical, glibc-specific point of view:
country_isbn is internally coded as a (UTF-8) string.
In source file it could be specified as a number (if it's single number
- note that some (>50) countries have more than one ISBN prefix) or as
a string (whether coded as unicode points, or directly).

If there is no formal specification of this field in source file format
(is it covered by ISO TR 30112?), used format would be just a matter of
convention.


-- 
Jakub Bogusz    http://qboosh.pl/

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-09-01 11:51                     ` Chris Leonard
  2013-09-01 15:09                       ` Jakub Bogusz
@ 2013-09-01 17:16                       ` keld
  1 sibling, 0 replies; 14+ messages in thread
From: keld @ 2013-09-01 17:16 UTC (permalink / raw)
  To: Chris Leonard; +Cc: Jakub Bogusz, libc-alpha, libc-locales

Hi

I have been travelling for the last week, and in meetings, so that is
why I have not returned to you with an answer to this. I did investigate 
a little, but did not find a satisfactioning answer.

Best regards
Keld

On Sun, Sep 01, 2013 at 07:50:28AM -0400, Chris Leonard wrote:
> Keld,
> 
> We are still at an impasse on the proper format for country_isbn.
> 
> Jakub believes that it should be quoted in unicode points, where as I
> beiieve it should be a simple numeric.
> 
> The specification you cited was not informative on this point,
> 
> Can you give us an informed (definitive) answer to this question?
> 
> I would very much like ot move Jakub's many patches forward t oreview
> and commit, but I need an answer on this question first.
> 
> 
> cjl
> 
> On Tue, Aug 27, 2013 at 8:02 PM, Chris Leonard <cjlhomeaddress@gmail.com> wrote:
> > On Tue, Aug 27, 2013 at 7:33 PM,  <keld@keldix.com> wrote:
> >> There is a newer locale specification available as
> >> ISO TR 30112, it describes most keywords that we have implemented
> >> in libc.  Else the old ISO TR 14652 has most info also.
> >>
> >> I think it would be useful to have a full description of
> >> libc - probably based on latest 30112 text.
> >>
> >> Best regards
> >> keld
> >>
> >
> >
> > Keld,
> >
> > Unfortunately, the version I could get my hands on (working draft 3)
> >
> > http://www.unicode.org/L2/L2011/11097-tr30112-wd3.pdf
> >
> > only mentions country_isbn in Appendix E and not in section 4.11, so
> > it does not shed light on the format question.
> >
> > cjl

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-08-28  0:03                   ` Chris Leonard
  2013-09-01 11:51                     ` Chris Leonard
@ 2013-09-01 17:55                     ` keld
  1 sibling, 0 replies; 14+ messages in thread
From: keld @ 2013-09-01 17:55 UTC (permalink / raw)
  To: Chris Leonard; +Cc: Jakub Bogusz, libc-alpha, libc-locales

On Tue, Aug 27, 2013 at 08:02:50PM -0400, Chris Leonard wrote:
> On Tue, Aug 27, 2013 at 7:33 PM,  <keld@keldix.com> wrote:
> > There is a newer locale specification available as
> > ISO TR 30112, it describes most keywords that we have implemented
> > in libc.  Else the old ISO TR 14652 has most info also.
> >
> > I think it would be useful to have a full description of
> > libc - probably based on latest 30112 text.
> >
> > Best regards
> > keld
> >
> 
> 
> Keld,
> 
> Unfortunately, the version I could get my hands on (working draft 3)
> 
> http://www.unicode.org/L2/L2011/11097-tr30112-wd3.pdf
> 
> only mentions country_isbn in Appendix E and not in section 4.11, so
> it does not shed light on the format question.

The latest draft of 30112 is also like that.
It is an error that country_isbn is missing in 4.11 
and it will be corrected in the next draft.

Anyway, most of the other keywords in 4.11 take a quoted_string according
to the BNF, so this is also intended for country_isbn.
This is evenmore needed if there can be more than one ISBN for a country.

Best regards
Keld

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix]
  2013-09-01 12:07           ` Chris Leonard
@ 2013-09-02  9:06             ` Jakub Bogusz
  0 siblings, 0 replies; 14+ messages in thread
From: Jakub Bogusz @ 2013-09-02  9:06 UTC (permalink / raw)
  To: Chris Leonard; +Cc: libc-alpha, libc-locales

On Sun, Sep 01, 2013 at 08:06:35AM -0400, Chris Leonard wrote:
> On Mon, Aug 26, 2013 at 2:56 PM, Jakub Bogusz <qboosh@pld-linux.org> wrote:
> 
> > I started the work to split the big patch, verify and update each change
> > (few parts required it).
> > Parts already processed can be seen at:
> > http://qboosh.pl/glibc-locale-fixes/
> > (glibc-locale_fixes.patch contains the remaining, unverified parts)
> 
> Jakub,
> 
> In order to assist with reviewing these many patches, would you be
> willing to include simple text comment lines immediately prior to the
> entries in Unicode points to simplify the review process.
> 
> For example, instead of
> 
> Fill in country_{car,isbn} for aa_ET.
> 
> +country_car   "<U0045><U0054><U0048>"
> 
> could you instead include
> 
> + %ETH
> +country_car   "<U0045><U0054><U0048>"
> 
> And the same for language name, etc. where they appear.  It would
> vastly simplfy the review process and speed acceptance of your patches
> once we have the country_isbn question resolved.

I'll try to do it gradually, but it will require some time to finish.

Meanwhile, I managed to finish splitting and verification of the
remaining LC_ADDRESS parts (also LC_TELEPHONE and language/territory
parts for a few locales).


-- 
Jakub Bogusz    http://qboosh.pl/

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2013-09-02  9:06 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-19 15:51 sr_ME locale country_isbn and int_prefix fix Jakub Bogusz
     [not found] ` <CAHdAataN0GXw5yXxrAR_J+eVckFiM0TDSmKsiaStq7yJ-mj=-w@mail.gmail.com>
     [not found]   ` <519D893F.70901@redhat.com>
     [not found]     ` <20130606081419.GA7652@mail>
     [not found]       ` <51B09452.8040009@redhat.com>
2013-08-27  6:33         ` LC_ADDRESS and other locale updates [was: sr_ME locale country_isbn and int_prefix fix] Jakub Bogusz
2013-08-26 21:26           ` Chris Leonard
2013-08-26 22:35             ` Chris Leonard
2013-08-27 14:04             ` Jakub Bogusz
2013-08-27 22:33               ` Chris Leonard
2013-08-28  0:44                 ` keld
2013-08-28  0:03                   ` Chris Leonard
2013-09-01 11:51                     ` Chris Leonard
2013-09-01 15:09                       ` Jakub Bogusz
2013-09-01 17:16                       ` keld
2013-09-01 17:55                     ` keld
2013-09-01 12:07           ` Chris Leonard
2013-09-02  9:06             ` Jakub Bogusz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).