[Bug localedata/14247] New: newlocale doesn't always set errno upon failure return

[Bug localedata/14247] New: newlocale doesn't always set errno upon failure return

[law at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=14247

             Bug #: 14247
           Summary: newlocale doesn't always set errno upon failure return
           Product: glibc
           Version: 2.15
            Status: NEW
          Severity: normal
          Priority: P2
         Component: localedata
        AssignedTo: unassigned@sourceware.org
        ReportedBy: law@redhat.com
                CC: libc-locales@sources.redhat.com
    Classification: Unclassified


Created attachment 6449
  --> http://sourceware.org/bugzilla/attachment.cgi?id=6449
Potential fix

newlocale() neglects to set errno to an appropriate value when failing, if it
has already been asked about the same incorrect locale name.

#include <stdio.h>
#include <errno.h>
#include <locale.h>

int
main(int argc, char **argv)
{
  locale_t loc;

  setlocale(LC_ALL, "C");

  errno = 0;
  loc = newlocale(LC_COLLATE_MASK | LC_CTYPE_MASK,
          "nb_no.utf8",
          0);
  printf("result = %p errno = %d\n", loc, errno);

  errno = 0;
  loc = newlocale(LC_COLLATE_MASK | LC_CTYPE_MASK,
          "nb_no.utf8",
          0);
  printf("result = %p errno = %d\n", loc, errno);

  return 0;
}


Actual results:
result = (nil) errno = 2
result = (nil) errno = 0

Expected results:
result = (nil) errno = 2
result = (nil) errno = 2     (or at least something other than 0)

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug localedata/14247] newlocale doesn't always set errno upon failure return

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|localedata                  |locale

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[kristian.spangsege at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

kristian.spangsege at gmail dot com <kristian.spangsege at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kristian.spangsege at gmail dot co
                   |                            |m

--- Comment #1 from kristian.spangsege at gmail dot com <kristian.spangsege at gmail dot com> ---
This bug is still present in GLIBC 2.31

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |carlos at redhat dot com
                 CC|                            |carlos at redhat dot com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
The fix is incomplete since when multiple paths are part of the lookup the test
case still fails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6449|0                           |1
           is patch|                            |
   Attachment #6449|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
Created attachment 15233
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15233&action=edit
0001-locale-Handle-loading-a-missing-locale-twice-Bug-142.patch

Fixes both locations that need fixing.

Adds a test case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
Final patch posted:
https://patchwork.sourceware.org/project/glibc/patch/20240227153513.1790813-1-carlos@redhat.com/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=827510

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=2252433

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/14247] newlocale doesn't always set errno upon failure return

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=14247

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=832516

-- 
You are receiving this mail because:
You are on the CC list for the bug.