[Bug localedata/17617] New: Race condition in localedata tests

[Bug localedata/17617] New: Race condition in localedata tests

[hjl.tools at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

            Bug ID: 17617
           Summary: Race condition in localedata tests
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: localedata
          Assignee: unassigned at sourceware dot org
          Reporter: hjl.tools at gmail dot com
                CC: libc-locales at sourceware dot org

When machine is under heavy load, I saw

FAIL: localedata/bug-iconv-trans
FAIL: localedata/tst-mbswcs6
FAIL: localedata/tst-trans
FAIL: localedata/tst-wctype
FAIL: localedata/tst_mbrlen
FAIL: localedata/tst_mbrtowc
FAIL: localedata/tst_mbsrtowcs
FAIL: localedata/tst_mbstowcs
FAIL: localedata/tst_mbtowc
FAIL: localedata/tst_swscanf
FAIL: localedata/tst_wcrtomb
FAIL: localedata/tst_wcsrtombs
FAIL: localedata/tst_wcstombs
FAIL: localedata/tst_wctob
FAIL: localedata/tst_wctomb

localedata/Makefile has

# Dependency for the locale files.  We actually make it depend only on
# one of the files.
$(addprefix $(objpfx),$(CTYPE_FILES)): %: \
  gen-locale.sh $(common-objpfx)locale/localedef Makefile \
  $(addprefix charmaps/,$(CHARMAPS)) $(addprefix locales/,$(LOCALE_SRCS))
        @$(SHELL) gen-locale.sh $(common-objpfx) \
                  '$(built-program-cmd-before-env)' '$(run-program-env)' \
                  '$(built-program-cmd-after-env)' $@; \
        $(evaluate-test)

$(addsuffix .out,$(addprefix $(objpfx),$(tests))): %: \
  $(addprefix $(objpfx),$(CTYPE_FILES))

$(objpfx)sort-test.out: sort-test.sh $(objpfx)collate-test $(objpfx)xfrm-test \
                       $(test-input-data) $(addprefix $(objpfx),$(CTYPE_FILES))
        $(SHELL) $< $(common-objpfx) '$(test-program-prefix-before-env)' \
          '$(run-program-env)' '$(test-program-prefix-after-env)' \
          $(test-input) \
          > $@; \
        $(evaluate-test)

However, there is no $(CTYPE_FILES) dependency for those tests
above, which fail at random under heavy load with parallel build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/17617] Race condition in localedata tests

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/17617] Race condition in localedata tests

[msebor at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

Martin Sebor <msebor at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at redhat dot com

--- Comment #1 from Martin Sebor <msebor at redhat dot com> ---
Also observed during 'make -j16 check' on powerpc and reported here:
https://sourceware.org/ml/libc-alpha/2015-08/msg00080.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/17617] Race condition in localedata tests

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|localedata                  |locale

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/17617] Race condition in localedata tests

[sje at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

sje at gcc dot gnu.org <sje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sje at gcc dot gnu.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/17617] Race condition in localedata tests

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |vapier at gentoo dot org
         Resolution|---                         |FIXED

--- Comment #2 from Mike Frysinger <vapier at gentoo dot org> ---
afaik, this has been resolved in latest master

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/17617] Race condition in localedata tests

[joseph at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Sat, 16 Apr 2016, vapier at gentoo dot org wrote:

>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |RESOLVED
>                  CC|                            |vapier at gentoo dot org
>          Resolution|---                         |FIXED
> 
> --- Comment #2 from Mike Frysinger <vapier at gentoo dot org> ---
> afaik, this has been resolved in latest master

Please set the milestone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug locale/17617] Race condition in localedata tests

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=17617

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.22

--- Comment #4 from Mike Frysinger <vapier at gentoo dot org> ---
i think it's at least 9f53d7ad577db870c4383b4378cd23131f516c42, but i'm only
remembering some of the threads that went by where we talked about parallel
locale gen issues at test time and then we made changes, and then people
stopped complaining :).

so going to assume it's fixed for at least glibc-2.22.  the code referenced in
comment #0 doesn't exist anymore in the same form, and we've tweaked deps
elsewhere.  if there's still a build failure, please post updated details.

-- 
You are receiving this mail because:
You are on the CC list for the bug.