[Bug localedata/18205] New: Wrong first_weekday and first_workday for be_BY*

[Bug localedata/18205] New: Wrong first_weekday and first_workday for be_BY*

[andrei.dziahel at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

            Bug ID: 18205
           Summary: Wrong first_weekday and first_workday for be_BY*
           Product: glibc
           Version: 2.21
            Status: NEW
          Severity: normal
          Priority: P2
         Component: localedata
          Assignee: unassigned at sourceware dot org
          Reporter: andrei.dziahel at gmail dot com
                CC: libc-locales at sourceware dot org

Created attachment 8227
  --> https://sourceware.org/bugzilla/attachment.cgi?id=8227&action=edit
Proposed patch to fix first_weekday & first_workday for be_BY locales

Reproducing:

1. Get a test program from
https://bug747346.bugzilla-attachments.gnome.org/attachment.cgi?id=300994,
compile it
2. Run it with LC_TIME=be_BY.utf8 ./a.out

Expected output:  

> first_weekday: 2
> week_1stday: 0
> Week start: 1

It's same output as one for ru_RU, uk_UA and other territories where week
begins with Monday.

What happens instead: the output is 
> first_weekday: 1
> week_1stday: 0
> Week start: 0
same as for en_US and other territories where week begins with Sunday

I've attached a (trivial?) patch which should fix this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] Wrong first_weekday and first_workday for be_BY*

[ihar.hrachyshka at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

booxter <ihar.hrachyshka at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ihar.hrachyshka at gmail dot com

--- Comment #1 from booxter <ihar.hrachyshka at gmail dot com> ---
The patch looks fine, being a be_BY@latin maintainer, I would like to see it
merged. Though I wonder whether we also need to define 'week' to start weekday
count from Monday too.

http://lh.2xlibre.net/values/week/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] Wrong first_weekday and first_workday for be_BY*

[andrei.dziahel at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

--- Comment #2 from Andrei Dziahel <andrei.dziahel at gmail dot com> ---
So release is near and what would a decision be? Should this patch be improved
or is it good as is and thus can be accepted? Or maybe it doesn't solve any
real problem?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] Wrong first_weekday and first_workday for be_BY*

[andrei.dziahel at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

--- Comment #3 from Andrei Dziahel <andrei.dziahel at gmail dot com> ---
TWIMC

I've noticed there's no maintainers' activity for a 6 months which raises some
questions. Is the issue description clear enough? Is my patch good enough? If
it isn't, what's wrong about it? Is there some vital information missing? Is
there anything at all I could do to help resolving this issue?

Thank you in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] Wrong first_weekday and first_workday for be_BY*

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com

--- Comment #4 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Andrei Dziahel from comment #3)
> TWIMC
> 
> I've noticed there's no maintainers' activity for a 6 months which raises
> some questions. Is the issue description clear enough? Is my patch good
> enough? If it isn't, what's wrong about it? Is there some vital information
> missing? Is there anything at all I could do to help resolving this issue?
> 
> Thank you in advance.

The last thing you need to provide is some kind of official justification for
your claims for be_BY.

Once you have such claims post your patch and description of change with
justification to libc-alpha@sourceware.org for review and inclusion. See:
https://sourceware.org/glibc/wiki/Contribution%20checklist

Your patch will get more visibility, review, and finally get checked in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] be_BY*: wrong first_weekday and first_workday

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vapier at gentoo dot org
            Summary|Wrong first_weekday and     |be_BY*: wrong first_weekday
                   |first_workday for be_BY*    |and first_workday

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] be_BY*: wrong first_weekday and first_workday

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|vapier at gentoo dot org           |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] be_BY*: wrong first_weekday and first_workday

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

--- Comment #5 from Mike Frysinger <vapier at gentoo dot org> ---
should be fixed by:
  https://sourceware.org/ml/libc-alpha/2016-04/msg00419.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/18205] be_BY*: wrong first_weekday and first_workday

[vapier at gentoo dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=18205

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.24

--- Comment #6 from Mike Frysinger <vapier at gentoo dot org> ---
should be fixed now:
https://sourceware.org/git/?p=glibc.git;a=commit;h=0a410e76f551c6e6cf6d128f618208049d6a952c

-- 
You are receiving this mail because:
You are on the CC list for the bug.