[Bug localedata/27320] localedata/gen-locale.sh failure in native build is ignored

["joseph at codesourcery dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27320

--- Comment #8 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
An appropriate fix would be to make any failure in 
localedata/gen-locale.sh produce a FAIL for the generated locale.

The first step in that is that gen-locale.sh should exit with error status 
on error from localedef, which it looks to me like it does (an explicit 
"exit 1").  The second step is that the makefile rule should use 
$(evaluate-test), which it also does (in gen-locales.mk).  So there are a 
few other issues to resolve:

* The locales should be listed in tests-special (like how 
timezone/Makefile does

tests-special += $(addprefix $(testdata)/, $(test-zones))

to get files built by zic listed as tests, for example).

* That listing in tests-special probably needs to be in the localedata/ 
directory as that's where the files in question are built.

* Then the FAIL would be in localedata/subdir-tests.sum.

* But you're using subdirs=string which prevents FAILs outside 
string/subdir-tests.sum from being considered in the process of merging 
FAILs from subdirectories.  Fixing the points above should ensure a FAIL 
when gen-locale.sh fails in a full testsuite run, but getting one if 
you're only building a non-localedata subdirectory may be harder.

-- 
You are receiving this mail because:
You are on the CC list for the bug.