[Bug localedata/27781] Please add the new rif_MA locale

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Ilyahoo Proshel <ip at ipshel dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|locale                      |localedata
                 CC|                            |libc-locales at sourceware dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[gunnarhj at ubuntu dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Gunnar Hjalmarsson <gunnarhj at ubuntu dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://launchpad.net/bugs/
                   |                            |1926312

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Ilyahoo Proshel <ip at ipshel dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13401|0                           |1
        is obsolete|                            |
                 CC|                            |ip at ipshel dot com

--- Comment #1 from Ilyahoo Proshel <ip at ipshel dot com> ---
Created attachment 13620
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13620&action=edit
Updated names

We update the names and text in the locale file

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Ilyahoo Proshel <ip at ipshel dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13620|Updated names               |rif_MA updated locale file
        description|                            |

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[carlos at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlos at redhat dot com
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-11-12
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
(In reply to Ilyahoo Proshel from comment #1)
> Created attachment 13620 [details]
> rif_MA updated locale file
> 
> We update the names and text in the locale file

This needs to be posted to libc-alpha@sourceware.org for review.

Along with that review it would be good if you could include a test case for
Tarifit:

- Add localedata/rif_MA.UTF-8.in with expected sort order for data.
- Add rif_MA.UTF-8 to test-input

This should add rif_MA.UTF-8 testing to glibc to ensure the sorting matches
your expectations and stays this way going forward. This prevents accidental
breakage in collation when refactoring during ISO 14651 updates.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Ilyahoo Proshel <ip at ipshel dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13620|0                           |1
        is obsolete|                            |

--- Comment #3 from Ilyahoo Proshel <ip at ipshel dot com> ---
Created attachment 13921
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13921&action=edit
updated rif_MA locale

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #4 from Ilyahoo Proshel <ip at ipshel dot com> ---
Created attachment 13922
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13922&action=edit
test input for rif_MA

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #5 from Ilyahoo Proshel <ip at ipshel dot com> ---
Dear maintainers,

I added localedata/rif_MA.UTF-8.in the I added rif_MA.UTF-8 to test-input. I
modified the original locale to prevent some errors.

make localedata/tests has been done without any errors.

Please find attached files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[adhemerval.zanella at linaro dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Adhemerval Zanella <adhemerval.zanella at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adhemerval.zanella at linaro dot o
                   |                            |rg

--- Comment #6 from Adhemerval Zanella <adhemerval.zanella at linaro dot org> ---
(In reply to Ilyahoo Proshel from comment #5)
> Dear maintainers,
> 
> I added localedata/rif_MA.UTF-8.in the I added rif_MA.UTF-8 to test-input. I
> modified the original locale to prevent some errors.
> 
> make localedata/tests has been done without any errors.
> 
> Please find attached files.

Please send any patch to libc-alpha [1], here are some links on how to
contribute [2].  Patches are only reviewed on the maillist.

[1] https://sourceware.org/mailman/listinfo/libc-alpha
[2] https://sourceware.org/glibc/wiki/Contribution%20checklist

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Mike FABIAN <maiku.fabian at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maiku.fabian at gmail dot com
           Assignee|unassigned at sourceware dot org   |maiku.fabian at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #7 from Mike FABIAN <maiku.fabian at gmail dot com> ---
Created attachment 14051
  --> https://sourceware.org/bugzilla/attachment.cgi?id=14051&action=edit
Slighly improved rif_MA

I used ASCII characters directly instead of <U...>, for example:

abday           "L<U1E25>e";/
                "Let";/
                "Ttl";/
                "Lar";/
                "Lex";/
                "Jje";/
                "Sbt"

Only for non ASCII characters we are still using the <U....> code point
notation, using the ASCII characters directly makes it a lot more readable.

I also added:

lang_name    "Tmazi<U0263>t"

Does that look OK to you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #8 from Ilyahoo Proshel <ip at ipshel dot com> ---
(In reply to Mike FABIAN from comment #7)
> Created attachment 14051 [details]
> Slighly improved rif_MA
> 
> I used ASCII characters directly instead of <U...>, for example:
> 
> abday           "L<U1E25>e";/
>                 "Let";/
>                 "Ttl";/
>                 "Lar";/
>                 "Lex";/
>                 "Jje";/
>                 "Sbt"
> 
> Only for non ASCII characters we are still using the <U....> code point
> notation, using the ASCII characters directly makes it a lot more readable.
> 
> I also added:
> 
> lang_name    "Tmazi<U0263>t"
> 
> Does that look OK to you?

Thank you for you help and your work on improving the locale.
everything seems to be ok. Just the name. it's a locale for "Tarifit", and not
"Tmazi<U0263>t". because the last one is another language.

And by the way. we did send the patch for the unmodified locale. and it pass
the build successfully, if you want to take a look here:
https://patchwork.sourceware.org/project/glibc/patch/20220125172555.2527278-1-ip@ipshel.com/

Thank you a lot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #9 from Mike FABIAN <maiku.fabian at gmail dot com> ---
https://en.wikipedia.org/wiki/Tarifit

The wikipedia article said that the endonym (The name of the language in
itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first one.

According to Wikipedia, “Tarifit” is the name of the language in English.

lang_name should contain the endonym whereas 

language   "Tarifit"

should contain the English name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #10 from Mike FABIAN <maiku.fabian at gmail dot com> ---
> And by the way. we did send the patch for the unmodified locale. and it pass
> the build successfully, if you want to take a look here:
> https://patchwork.sourceware.org/project/glibc/patch/20220125172555.2527278-
> 1-ip@ipshel.com/

Yes, I read your mail and the attached patch and I took the
the test input file from the patch in the mail because the one
attached to the bug report here does not work (i.e. sorting the test file
attached to the bug does not reproduce the test input).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #11 from Mike FABIAN <maiku.fabian at gmail dot com> ---
(In reply to Mike FABIAN from comment #9)
> https://en.wikipedia.org/wiki/Tarifit
> 
> The wikipedia article said that the endonym (The name of the language in
> itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first
> one.
> 
> According to Wikipedia, “Tarifit” is the name of the language in English.
> 
> lang_name should contain the endonym whereas 
> 
> language   "Tarifit"
> 
> should contain the English name.

Wikipedia> Its own speakers simply call it "Tamazight", a term also often
applied Wikipedia> in a broader sense to the Berber language across North
Africa in Wikipedia> general.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #12 from Ilyahoo Proshel <ip at ipshel dot com> ---
(In reply to Mike FABIAN from comment #11)
> (In reply to Mike FABIAN from comment #9)
> > https://en.wikipedia.org/wiki/Tarifit
> > 
> > The wikipedia article said that the endonym (The name of the language in
> > itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first
> > one.
> > 
> > According to Wikipedia, “Tarifit” is the name of the language in English.
> > 
> > lang_name should contain the endonym whereas 
> > 
> > language   "Tarifit"
> > 
> > should contain the English name.
> 
> Wikipedia> Its own speakers simply call it "Tamazight", a term also often
> applied Wikipedia> in a broader sense to the Berber language across North
> Africa in Wikipedia> general.

Tamazight is the mother language where multiple other languages inherited from
it. Including Tarifit. 
And what’s apply for Tarifit does mean that can apply for another sub-tamazight
languages, and vice versa. So we believe that lang_name should be “Tarifit”.

Should we resend the patch by email with your improvements?
Thank you very much for your time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #13 from Mike FABIAN <maiku.fabian at gmail dot com> ---
> Tamazight is the mother language where multiple other languages inherited
> from it. Including Tarifit. 
> And what’s apply for Tarifit does mean that can apply for another
> sub-tamazight languages, and vice versa. So we believe that lang_name should
> be “Tarifit”.
> 
> Should we resend the patch by email with your improvements?
> Thank you very much for your time.

No, you don’t need to resend the patch, I just change lang_name to “Tarifit”
and then I can commit it, I think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #14 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mike Fabian <mfabian@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=189906b68742e8b26bca7103a7f3c221de36d0fd

commit 189906b68742e8b26bca7103a7f3c221de36d0fd
Author: Ilyahoo Proshel <ip@ipshel.com>
Date:   Tue Apr 5 13:23:16 2022 +0200

    Add rif_MA locale [BZ #27781]

    Resolves: BZ #27781

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

Mike FABIAN <maiku.fabian at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Mike FABIAN <maiku.fabian at gmail dot com> ---
Fixed in glibc master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/27781] Please add the new rif_MA locale

[ip at ipshel dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

--- Comment #16 from Ilyahoo Proshel <ip at ipshel dot com> ---
Thank you, We really appreciate your time and your contribution.(In reply to
Mike FABIAN from comment #15)
> Fixed in glibc master.

-- 
You are receiving this mail because:
You are on the CC list for the bug.