* [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
@ 2023-05-02 10:49 bugzilla at tecnocode dot co.uk
2023-05-02 11:18 ` [Bug localedata/30412] " schwab@linux-m68k.org
` (10 more replies)
0 siblings, 11 replies; 12+ messages in thread
From: bugzilla at tecnocode dot co.uk @ 2023-05-02 10:49 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
Bug ID: 30412
Summary: d_t_fmt in id_ID uses %r placeholder but am_pm and
t_fmt_ampm are undefined
Product: glibc
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: localedata
Assignee: unassigned at sourceware dot org
Reporter: bugzilla at tecnocode dot co.uk
CC: libc-locales at sourceware dot org
Target Milestone: ---
See https://gitlab.gnome.org/GNOME/glib/-/issues/2967#note_1719623 for context.
The following definitions currently exist in localedata/locales/id_ID
(https://github.com/bminor/glibc/blob/master/localedata/locales/id_ID):
```
d_t_fmt "%a %d %b %Y %r"
date_fmt "%a %d %b %Y %r %Z"
am_pm "";""
t_fmt_ampm ""
```
It seems inconsistent to use `%r` in `d_t_fmt`/`date_fmt` while also having
`am_pm` and `t_fmt_ampm` undefined.
Apparently `date` uses a fallback in this case. GLib (for better or worse) does
not, which causes date formatting using `d_t_fmt`/`date_fmt` to fail in id_ID.
We could change GLib to apply a fallback, but in this case it looks to me like
it’s the localedata that’s wrong.
There are some proposed changes to the locale strings here:
https://gitlab.gnome.org/GNOME/glib/-/issues/2967#note_1713065, based on the
fact that Indian standard time uses the 24-hour clock rather than 12-hour, so
`d_t_fmt`/`date_fmt` should not use `%r` at all.
The proposed changes are:
```
-d_t_fmt "%a %d %b %Y %r"
-date_fmt "%a %d %b %Y %r %Z"
+d_t_fmt "%a %d %b %Y %T %Z"
+date_fmt "%a %d %b %Y %T %Z"
```
and
```
-am_pm "";""
-t_fmt_ampm ""
+am_pm "AM";"PM"
+t_fmt_ampm "%I:%M:%S %p"
```
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
@ 2023-05-02 11:18 ` schwab@linux-m68k.org
2023-05-02 12:05 ` p3732 at getgoogleoff dot me
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: schwab@linux-m68k.org @ 2023-05-02 11:18 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
If t_fmt_ampm is empty, it defaults to "%I:%M:%S %p".
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
2023-05-02 11:18 ` [Bug localedata/30412] " schwab@linux-m68k.org
@ 2023-05-02 12:05 ` p3732 at getgoogleoff dot me
2023-05-15 14:33 ` bugzilla at tecnocode dot co.uk
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: p3732 at getgoogleoff dot me @ 2023-05-02 12:05 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
Peter Eisenmann <p3732 at getgoogleoff dot me> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p3732 at getgoogleoff dot me
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
2023-05-02 11:18 ` [Bug localedata/30412] " schwab@linux-m68k.org
2023-05-02 12:05 ` p3732 at getgoogleoff dot me
@ 2023-05-15 14:33 ` bugzilla at tecnocode dot co.uk
2023-12-18 8:11 ` maiku.fabian at gmail dot com
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: bugzilla at tecnocode dot co.uk @ 2023-05-15 14:33 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #2 from Philip Withnall <bugzilla at tecnocode dot co.uk> ---
(In reply to Andreas Schwab from comment #1)
> If t_fmt_ampm is empty, it defaults to "%I:%M:%S %p".
And presumably hence if am_pm is empty then it also defaults to `"AM";"PM"` for
this to work?
Would your preferred fix be for
1. localedata to use `%T %Z` rather than `%r` in `d_t_fmt`/`date_fmt`; or
2. GLib to use `%I:%M:%S %p` for `t_fmt_ampm` if it’s otherwise undefined?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (2 preceding siblings ...)
2023-05-15 14:33 ` bugzilla at tecnocode dot co.uk
@ 2023-12-18 8:11 ` maiku.fabian at gmail dot com
2023-12-18 8:22 ` maiku.fabian at gmail dot com
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: maiku.fabian at gmail dot com @ 2023-12-18 8:11 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
Mike FABIAN <maiku.fabian at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |maiku.fabian at gmail dot com
--- Comment #3 from Mike FABIAN <maiku.fabian at gmail dot com> ---
This seems related:
https://patchwork.sourceware.org/project/glibc/patch/20230821035530.9075-1-rushing27alien@gmail.com/
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (3 preceding siblings ...)
2023-12-18 8:11 ` maiku.fabian at gmail dot com
@ 2023-12-18 8:22 ` maiku.fabian at gmail dot com
2023-12-18 8:44 ` rushing27alien at gmail dot com
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: maiku.fabian at gmail dot com @ 2023-12-18 8:22 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
Mike FABIAN <maiku.fabian at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2.39
Assignee|unassigned at sourceware dot org |maiku.fabian at gmail dot com
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (4 preceding siblings ...)
2023-12-18 8:22 ` maiku.fabian at gmail dot com
@ 2023-12-18 8:44 ` rushing27alien at gmail dot com
2023-12-18 9:23 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rushing27alien at gmail dot com @ 2023-12-18 8:44 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #4 from Zhafran Rama Azmi <rushing27alien at gmail dot com> ---
Hey, I would like to inform that i'm currently having this on hold, got
one thing wrong, that is it turns out first weekday is indeed sunday
here, so I'm going to correct that, rest are still correct. I would
also like to collect evidence and the likes
Pada Sen, 18 Des 2023 pada 08:22:26 +00:00:00, maiku.fabian at gmail
dot com via Libc-locales <libc-locales@sourceware.org> menulis:
> <https://sourceware.org/bugzilla/show_bug.cgi?id=30412>
>
> Mike FABIAN <maiku.fabian at gmail dot com> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Target Milestone|--- |2.39
> Assignee|unassigned at sourceware dot org |maiku.fabian
> at gmail dot com
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (5 preceding siblings ...)
2023-12-18 8:44 ` rushing27alien at gmail dot com
@ 2023-12-18 9:23 ` cvs-commit at gcc dot gnu.org
2023-12-18 9:25 ` maiku.fabian at gmail dot com
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-12-18 9:23 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #5 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mike Fabian <mfabian@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=12ab77e893479a1f7d4666082a48efad79777bb9
commit 12ab77e893479a1f7d4666082a48efad79777bb9
Author: RushingAlien <rushing27alien@gmail.com>
Date: Mon Aug 21 10:55:30 2023 +0700
id_ID: Update Time Locales
Hello! I am Indonesian, was born and raised in Indonesia and still do live
in
Indonesia.
This patch brings a few changes to the time locales of id_ID, which
includes :
\- Defining am_pm and time_fmpt_ampm
\- Changing time_fmt and d_t_fmt to use the 24-hour format
\- Changing first_weekday to Monday
This is a squashed version of what is previously a 5 patch set
Here are reasons and details of the changes :
Change 1 part 1
id_ID: Define `am_pm` string
Current formatting does not define am_pm string, leading to AM and PM
not being specified in 12 H time format. This change defines the string
by changing it from an empty string to "AM";"PM".
output of `date +%r`:
before commit: 01:23
after commit: 01:23 PM
Change 1 part 2
id_ID: Define time_fmt_ampm, change from an empty string
Currently, time_fmpt_ampm is set to an empty string, causing some
programs to not be able to display time in the 12-hour format, for
example, glib: https://gitlab.gnome.org/GNOME/glib/-/issues/2967.
This commit changes it from an empty string to "%I:%M:%S %p"
Change 2 part 1
id_ID: Use 24-hour format for time_fmt
Indonesian standard and formal time format uses the 24-hour format inst-
ead of the 12-hour format. This commit aims to change the id_ID locale's
time_fmt to match that accordingly.
Change 2 part 2
id_ID: Use 24-hour format for d_t_fmt.
Indonesian standard and formal time format uses the 24-hour format inst-
ead of the 12-hour format. This commit aims to change the id_ID locale's
d_t_fmt to match that accordingly.
Change 3
id_ID: Change first_weekday to monday
Indonesian calendar starts of the week with Monday, let's comply
Message-ID: <20230821035530.9075-1-rushing27alien@gmail.com>
Resolves: BZ # 30412
Reviewed-by: Mike Fabian <mfabian@redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (6 preceding siblings ...)
2023-12-18 9:23 ` cvs-commit at gcc dot gnu.org
@ 2023-12-18 9:25 ` maiku.fabian at gmail dot com
2023-12-19 7:00 ` rushing27alien at gmail dot com
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: maiku.fabian at gmail dot com @ 2023-12-18 9:25 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #6 from Mike FABIAN <maiku.fabian at gmail dot com> ---
(In reply to Zhafran Rama Azmi from comment #4)
> Created attachment 15262 [details]
> attachment-3741274-0.html
>
> Hey, I would like to inform that i'm currently having this on hold, got
> one thing wrong, that is it turns out first weekday is indeed sunday
> here, so I'm going to correct that, rest are still correct. I would
> also like to collect evidence and the likes
Oh, sorry, I didn't see that before committing.
So I need to correct the first weekday to Sunday?
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (7 preceding siblings ...)
2023-12-18 9:25 ` maiku.fabian at gmail dot com
@ 2023-12-19 7:00 ` rushing27alien at gmail dot com
2023-12-19 10:23 ` cvs-commit at gcc dot gnu.org
2023-12-19 10:24 ` maiku.fabian at gmail dot com
10 siblings, 0 replies; 12+ messages in thread
From: rushing27alien at gmail dot com @ 2023-12-19 7:00 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #7 from Zhafran Rama Azmi <rushing27alien at gmail dot com> ---
Yes, that is correct
Pada Sen, 18 Des 2023 pada 09:25:26 +00:00:00, maiku.fabian at gmail
dot com via Libc-locales <libc-locales@sourceware.org> menulis:
> <https://sourceware.org/bugzilla/show_bug.cgi?id=30412>
>
> --- Comment #6 from Mike FABIAN <maiku.fabian at gmail dot com> ---
> (In reply to Zhafran Rama Azmi from comment #4)
>> Created attachment 15262 [details]
>> attachment-3741274-0.html
>>
>> Hey, I would like to inform that i'm currently having this on hold,
>> got
>> one thing wrong, that is it turns out first weekday is indeed sunday
>> here, so I'm going to correct that, rest are still correct. I would
>> also like to collect evidence and the likes
>
> Oh, sorry, I didn't see that before committing.
>
> So I need to correct the first weekday to Sunday?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (8 preceding siblings ...)
2023-12-19 7:00 ` rushing27alien at gmail dot com
@ 2023-12-19 10:23 ` cvs-commit at gcc dot gnu.org
2023-12-19 10:24 ` maiku.fabian at gmail dot com
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-12-19 10:23 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
--- Comment #8 from Sourceware Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mike Fabian <mfabian@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1e7025250843f234ac6743dd0dcd8aa9018bae3f
commit 1e7025250843f234ac6743dd0dcd8aa9018bae3f
Author: Mike FABIAN <mfabian@redhat.com>
Date: Tue Dec 19 10:48:42 2023 +0100
localedata: id_ID: change first weekday to Sunday
Resolves: BZ # 30412
See: https://sourceware.org/bugzilla/show_bug.cgi?id=30412#c7
CLDR also has ID in the list of territories which have Sunday as the
first day of the week.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug localedata/30412] d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
` (9 preceding siblings ...)
2023-12-19 10:23 ` cvs-commit at gcc dot gnu.org
@ 2023-12-19 10:24 ` maiku.fabian at gmail dot com
10 siblings, 0 replies; 12+ messages in thread
From: maiku.fabian at gmail dot com @ 2023-12-19 10:24 UTC (permalink / raw)
To: libc-locales
https://sourceware.org/bugzilla/show_bug.cgi?id=30412
Mike FABIAN <maiku.fabian at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #9 from Mike FABIAN <maiku.fabian at gmail dot com> ---
Fixed in glibc master.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-12-19 10:24 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-02 10:49 [Bug localedata/30412] New: d_t_fmt in id_ID uses %r placeholder but am_pm and t_fmt_ampm are undefined bugzilla at tecnocode dot co.uk
2023-05-02 11:18 ` [Bug localedata/30412] " schwab@linux-m68k.org
2023-05-02 12:05 ` p3732 at getgoogleoff dot me
2023-05-15 14:33 ` bugzilla at tecnocode dot co.uk
2023-12-18 8:11 ` maiku.fabian at gmail dot com
2023-12-18 8:22 ` maiku.fabian at gmail dot com
2023-12-18 8:44 ` rushing27alien at gmail dot com
2023-12-18 9:23 ` cvs-commit at gcc dot gnu.org
2023-12-18 9:25 ` maiku.fabian at gmail dot com
2023-12-19 7:00 ` rushing27alien at gmail dot com
2023-12-19 10:23 ` cvs-commit at gcc dot gnu.org
2023-12-19 10:24 ` maiku.fabian at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).