From: Maxim Kuvyrkov <maxim@codesourcery.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: Carlos O'Donell <carlos@systemhalted.org>,
<libc-ports@sourceware.org>, <pinskia@gmail.com>
Subject: Re: [patch, mips] More mips memcpy improvements
Date: Wed, 28 Nov 2012 18:59:00 -0000 [thread overview]
Message-ID: <0959F771-16A8-4D4B-9372-907A07BB46B1@codesourcery.com> (raw)
In-Reply-To: <1354128832.22862.223.camel@ubuntu-sellcey>
On 29/11/2012, at 7:53 AM, Steve Ellcey wrote:
> On Wed, 2012-11-28 at 09:46 -0500, Carlos O'Donell wrote:
>>
...
>> I will note that I'm not comfortable pushing a patch like this so
>> close to the 2.17 freeze.
>>
>> My preference would be that 2.17 goes out the door, then once the
>> freeze is over we put this patch into trunk and then everyone can test
>> it and ensure that what we get is continual incremental improvement.
I second this.
>>
>> Cheers,
>> Carlos.
>
...
> I haven't run the glibc testsuite
> with this memcpy, I used a combination of memcpy specific tests I wrote
> plus GCC testing for verification. I will run the glibc testsuite
> today, it hasn't been clean in the past for me (before I made any
> changes) and I don't expect it to be so now but I will report on my
> results when I have them.
You don't need to have clean test results; as long as your patch doesn't cause any new failures, it is fine. [Of course, this is assuming that the testsuite is functional, i.e., >80% tests PASS.]
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics
next prev parent reply other threads:[~2012-11-28 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 20:37 Steve Ellcey
2012-11-28 7:43 ` Maxim Kuvyrkov
2012-11-28 14:46 ` Carlos O'Donell
2012-11-28 18:54 ` Steve Ellcey
2012-11-28 18:59 ` Maxim Kuvyrkov [this message]
2012-11-28 19:03 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0959F771-16A8-4D4B-9372-907A07BB46B1@codesourcery.com \
--to=maxim@codesourcery.com \
--cc=carlos@systemhalted.org \
--cc=libc-ports@sourceware.org \
--cc=pinskia@gmail.com \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).