From: Maxim Kuvyrkov <maxim@codesourcery.com>
To: Steve Ellcey <sellcey@mips.com>
Cc: <libc-ports@sourceware.org>, <pinskia@gmail.com>
Subject: Re: [patch, mips] More mips memcpy improvements
Date: Wed, 28 Nov 2012 07:43:00 -0000 [thread overview]
Message-ID: <9DE6D84C-701B-494C-9906-351CA25E9274@codesourcery.com> (raw)
In-Reply-To: <1f415392-abbf-4875-9543-ef1ff49206bf@EXCHHUB01.MIPS.com>
On 28/11/2012, at 9:37 AM, Steve Ellcey wrote:
...
> Andrew and Maxim, could you take a look at this new version and see if it
> works OK for you?
Correctness-wise, the patch does not trigger any faults on the benchmark that I'm using, so that's good. Performance-wise, I didn't see any significant difference. It may be that XLP's cache doesn't benefit from using prepare-for-store hints. In any case, the patch doesn't regress performance, so I'm OK with it.
Steve, did you run normal glibc testsuite on this patch with no failures?
Thanks,
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics
next prev parent reply other threads:[~2012-11-28 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 20:37 Steve Ellcey
2012-11-28 7:43 ` Maxim Kuvyrkov [this message]
2012-11-28 14:46 ` Carlos O'Donell
2012-11-28 18:54 ` Steve Ellcey
2012-11-28 18:59 ` Maxim Kuvyrkov
2012-11-28 19:03 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DE6D84C-701B-494C-9906-351CA25E9274@codesourcery.com \
--to=maxim@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=pinskia@gmail.com \
--cc=sellcey@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).