* Ports updates for NPTL _internal aliases change
@ 2012-05-30 10:01 Joseph S. Myers
2012-05-30 13:54 ` Carlos O'Donell
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Joseph S. Myers @ 2012-05-30 10:01 UTC (permalink / raw)
To: libc-ports
I've applied these changes to update the ARM and MIPS ports for the move
of NPTL to use hidden_def instead of _internal function aliases.
Other architectures (alpha, ia64, hppa, m68k, tile) will need similar
changes. hppa does more complicated things with _internal function names
and I don't know exactly what will be right there.
diff --git a/ChangeLog.arm b/ChangeLog.arm
index ec63edb..1d684d2 100644
--- a/ChangeLog.arm
+++ b/ChangeLog.arm
@@ -1,3 +1,8 @@
+2012-05-30 Joseph Myers <joseph@codesourcery.com>
+
+ * sysdeps/unix/sysv/linux/arm/nptl/pthread_once.c: Replace
+ _internal alias by hidden_def.
+
2012-05-26 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/arm/syscalls.list (chown): New.
diff --git a/ChangeLog.mips b/ChangeLog.mips
index b7c1ff3..d058589 100644
--- a/ChangeLog.mips
+++ b/ChangeLog.mips
@@ -1,3 +1,8 @@
+2012-05-30 Joseph Myers <joseph@codesourcery.com>
+
+ * sysdeps/unix/sysv/linux/mips/nptl/pthread_once.c: Replace
+ _internal alias by hidden_def.
+
2012-05-26 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/mips/mips32/nptl/libcidn.abilist: New
diff --git a/sysdeps/unix/sysv/linux/arm/nptl/pthread_once.c b/sysdeps/unix/sysv/linux/arm/nptl/pthread_once.c
index 5c6d26d..eea1287 100644
--- a/sysdeps/unix/sysv/linux/arm/nptl/pthread_once.c
+++ b/sysdeps/unix/sysv/linux/arm/nptl/pthread_once.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2004, 2005 Free Software Foundation, Inc.
+/* Copyright (C) 2004-2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -86,7 +86,7 @@ __pthread_once (pthread_once_t *once_control, void (*init_routine) (void))
return 0;
}
weak_alias (__pthread_once, pthread_once)
-strong_alias (__pthread_once, __pthread_once_internal)
+hidden_def (__pthread_once)
#if defined(__USING_SJLJ_EXCEPTIONS__) && !defined(__PIC__)
/* When statically linked, if pthread_create is used, this file
diff --git a/sysdeps/unix/sysv/linux/mips/nptl/pthread_once.c b/sysdeps/unix/sysv/linux/mips/nptl/pthread_once.c
index 0b62076..308da8b 100644
--- a/sysdeps/unix/sysv/linux/mips/nptl/pthread_once.c
+++ b/sysdeps/unix/sysv/linux/mips/nptl/pthread_once.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2003, 2004, 2005 Free Software Foundation, Inc.
+/* Copyright (C) 2003-2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Jakub Jelinek <jakub@redhat.com>, 2003.
@@ -90,4 +90,4 @@ __pthread_once (once_control, init_routine)
return 0;
}
weak_alias (__pthread_once, pthread_once)
-strong_alias (__pthread_once, __pthread_once_internal)
+hidden_def (__pthread_once)
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ports updates for NPTL _internal aliases change
2012-05-30 13:54 ` Carlos O'Donell
@ 2012-05-30 13:54 ` Joseph S. Myers
0 siblings, 0 replies; 5+ messages in thread
From: Joseph S. Myers @ 2012-05-30 13:54 UTC (permalink / raw)
To: Carlos O'Donell; +Cc: libc-ports
On Wed, 30 May 2012, Carlos O'Donell wrote:
> On 5/30/2012 6:00 AM, Joseph S. Myers wrote:
> > I've applied these changes to update the ARM and MIPS ports for the move
> > of NPTL to use hidden_def instead of _internal function aliases.
> >
> > Other architectures (alpha, ia64, hppa, m68k, tile) will need similar
> > changes. hppa does more complicated things with _internal function names
> > and I don't know exactly what will be right there.
>
> Yes, for hppa the Linuxthreads->NPTL transition was more difficult,
> and required a wrapper around pthread_cond* functions to manage the
> state of a possibly statically initialized pthread_cond*.
>
> We call the _internal functions from the wrappers after initializing
> pthread_cond* variables.
>
> Is that still possible?
Yes, that's still possible. What we're eliminating is use of _internal
aliases for the same purpose as things such as hidden_def (INTDEF / INTUSE
elimination, bug 14132); if the _internal name is actually wrapped rather
than being another name for the same function, that's fine.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ports updates for NPTL _internal aliases change
2012-05-30 10:01 Ports updates for NPTL _internal aliases change Joseph S. Myers
@ 2012-05-30 13:54 ` Carlos O'Donell
2012-05-30 13:54 ` Joseph S. Myers
2012-05-30 18:23 ` Richard Henderson
2012-05-31 4:29 ` [PATCH] ia64: use hidden_def with internal pthread funcs Mike Frysinger
2 siblings, 1 reply; 5+ messages in thread
From: Carlos O'Donell @ 2012-05-30 13:54 UTC (permalink / raw)
To: Joseph S. Myers; +Cc: libc-ports
On 5/30/2012 6:00 AM, Joseph S. Myers wrote:
> I've applied these changes to update the ARM and MIPS ports for the move
> of NPTL to use hidden_def instead of _internal function aliases.
>
> Other architectures (alpha, ia64, hppa, m68k, tile) will need similar
> changes. hppa does more complicated things with _internal function names
> and I don't know exactly what will be right there.
Yes, for hppa the Linuxthreads->NPTL transition was more difficult,
and required a wrapper around pthread_cond* functions to manage the
state of a possibly statically initialized pthread_cond*.
We call the _internal functions from the wrappers after initializing
pthread_cond* variables.
Is that still possible?
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Ports updates for NPTL _internal aliases change
2012-05-30 10:01 Ports updates for NPTL _internal aliases change Joseph S. Myers
2012-05-30 13:54 ` Carlos O'Donell
@ 2012-05-30 18:23 ` Richard Henderson
2012-05-31 4:29 ` [PATCH] ia64: use hidden_def with internal pthread funcs Mike Frysinger
2 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2012-05-30 18:23 UTC (permalink / raw)
To: libc-ports
On 05/30/2012 03:00 AM, Joseph S. Myers wrote:
> Other architectures (alpha, ia64, hppa, m68k, tile) will need similar
> changes. hppa does more complicated things with _internal function names
> and I don't know exactly what will be right there.
Done for alpha. Obvious patch elided.
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ia64: use hidden_def with internal pthread funcs
2012-05-30 10:01 Ports updates for NPTL _internal aliases change Joseph S. Myers
2012-05-30 13:54 ` Carlos O'Donell
2012-05-30 18:23 ` Richard Henderson
@ 2012-05-31 4:29 ` Mike Frysinger
2 siblings, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2012-05-31 4:29 UTC (permalink / raw)
To: libc-ports
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
ChangeLog.ia64 | 3 +++
sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c | 2 +-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/ChangeLog.ia64 b/ChangeLog.ia64
index 3a144b4..c9e9ea7 100644
--- a/ChangeLog.ia64
+++ b/ChangeLog.ia64
@@ -3,6 +3,9 @@
* sysdeps/unix/sysv/linux/ia64/syscalls.list: Remove
__connect_internal alias.
+ * sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c: Replace
+ _internal alias by hidden_def.
+
2012-05-25 Mike Frysinger <vapier@gentoo.org>
* sysdeps/unix/sysv/linux/ia64/nptl/libc.abilist: Update.
diff --git a/sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c b/sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c
index 1f22a8b..7730935 100644
--- a/sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c
+++ b/sysdeps/unix/sysv/linux/ia64/nptl/pthread_once.c
@@ -90,4 +90,4 @@ __pthread_once (once_control, init_routine)
return 0;
}
weak_alias (__pthread_once, pthread_once)
-strong_alias (__pthread_once, __pthread_once_internal)
+hidden_def (__pthread_once)
--
1.7.8.6
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-31 4:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-30 10:01 Ports updates for NPTL _internal aliases change Joseph S. Myers
2012-05-30 13:54 ` Carlos O'Donell
2012-05-30 13:54 ` Joseph S. Myers
2012-05-30 18:23 ` Richard Henderson
2012-05-31 4:29 ` [PATCH] ia64: use hidden_def with internal pthread funcs Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).