public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Torvald Riegel <triegel@redhat.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Richard Henderson <rth@twiddle.net>,
	       Siddhesh Poyarekar <siddhesh@redhat.com>,
	libc-ports@sourceware.org,        libc-alpha@sourceware.org
Subject: Re: PI mutex support for pthread_cond_* now in nptl
Date: Tue, 19 Feb 2013 20:06:00 -0000	[thread overview]
Message-ID: <1361304381.581.80.camel@triegel.csb> (raw)
In-Reply-To: <Pine.LNX.4.64.1302191714120.8011@digraph.polyomino.org.uk>

On Tue, 2013-02-19 at 17:18 +0000, Joseph S. Myers wrote:
> On Tue, 19 Feb 2013, Richard Henderson wrote:
> 
> > Any chance we can move these macros into a generic linux header?
> > Given that we're using INTERNAL_SYSCALL macros, the definitions ought to be
> > the same for all targets.
> 
> Generally most of lowlevellock.h should probably be shared between 
> architectures.  (If some architectures don't implement a particular 
> feature as of a particular kernel version, that's a matter for 
> kernel-features.h and __ASSUME_* conditionals.)

On a related note: What are the reasons to have arch-specific assembler
versions of many of the synchronization operations?  I would be
surprised if they'd provide a significant performance advantage; has
anyone recent measurements for this?

It seems to me that it would be useful to consolidate the different
versions that exist for the synchronization operations into shared C
code as long as this doesn't make a significant performance difference.
They are all based on atomic operations and futex operations, both of
which we have in C code (especially if we have compilers that support
the C11 memory model).  Or are there other reasons for keeping different
versions that I'm not aware of?


Torvald

  parent reply	other threads:[~2013-02-19 20:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 10:56 Siddhesh Poyarekar
2013-02-18 23:50 ` Joseph S. Myers
2013-02-19  0:50   ` Joseph S. Myers
2013-02-19 16:42 ` Richard Henderson
2013-02-19 16:49   ` Siddhesh Poyarekar
2013-02-19 17:18   ` Joseph S. Myers
2013-02-19 17:21     ` Siddhesh Poyarekar
2013-02-19 20:06     ` Torvald Riegel [this message]
2013-02-20 18:13       ` Steven Munroe
2013-02-20 20:25         ` Torvald Riegel
2013-02-20 22:04           ` Roland McGrath
2013-02-20 22:41           ` Steven Munroe
2013-02-21  4:32           ` Siddhesh Poyarekar
     [not found]     ` <1361304381.581.80.camel__6928.53579898856$1361304432$gmane$org@triegel.csb>
2013-02-22  4:11       ` Andi Kleen
     [not found] ` <5123AB55.2070100__45742.2411222526$1361292204$gmane$org@twiddle.net>
2013-02-19 17:01   ` Andreas Schwab
2013-02-19 17:18     ` Siddhesh Poyarekar
2013-02-19 17:39       ` Andreas Schwab
2013-02-19 17:52         ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361304381.581.80.camel@triegel.csb \
    --to=triegel@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libc-ports@sourceware.org \
    --cc=rth@twiddle.net \
    --cc=siddhesh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).