public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] ia64: fix set-but-unused warnings with syscalls
@ 2013-03-11  3:02 Mike Frysinger
  0 siblings, 0 replies; only message in thread
From: Mike Frysinger @ 2013-03-11  3:02 UTC (permalink / raw)
  To: libc-ports

These macros often set up a variable that later macros sometimes do
not use.  Add unused attribute to avoid that.

Similarly, the ia64 code tends to check the err field rather than
the val (which is opposite of most arches) leading to the same
kind of warning.  Replace this with a dummy reference.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 ports/sysdeps/unix/sysv/linux/ia64/sysdep.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ports/sysdeps/unix/sysv/linux/ia64/sysdep.h b/ports/sysdeps/unix/sysv/linux/ia64/sysdep.h
index c6fce13..96f6a4e 100644
--- a/ports/sysdeps/unix/sysv/linux/ia64/sysdep.h
+++ b/ports/sysdeps/unix/sysv/linux/ia64/sysdep.h
@@ -252,7 +252,7 @@
     _retval; })
 
 #undef INTERNAL_SYSCALL_DECL
-#define INTERNAL_SYSCALL_DECL(err) long int err
+#define INTERNAL_SYSCALL_DECL(err) long int err __attribute__ ((unused))
 
 #undef INTERNAL_SYSCALL
 #define INTERNAL_SYSCALL_NCS(name, err, nr, args...)	\
@@ -264,7 +264,10 @@
   INTERNAL_SYSCALL_NCS (__NR_##name, err, nr, ##args)
 
 #undef INTERNAL_SYSCALL_ERROR_P
-#define INTERNAL_SYSCALL_ERROR_P(val, err)	(err == -1)
+#define INTERNAL_SYSCALL_ERROR_P(val, err)		\
+  ({ (void) (val);					\
+     (err == -1);					\
+  })
 
 #undef INTERNAL_SYSCALL_ERRNO
 #define INTERNAL_SYSCALL_ERRNO(val, err)	(val)
-- 
1.8.1.2

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-03-11  3:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-11  3:02 [PATCH] ia64: fix set-but-unused warnings with syscalls Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).