From: Richard Henderson <rth@twiddle.net>
To: libc-ports@sourceware.org
Subject: [COMMITTED] BZ #15583: r7 uninitialized in strcpy.S when ARM_HAS_T2 undefined
Date: Wed, 05 Jun 2013 22:51:00 -0000 [thread overview]
Message-ID: <1370472686-3182-1-git-send-email-rth@twiddle.net> (raw)
---
A shockingly obvious typo. Tested on a15 with CC='gcc -march=armv6',
verifying that the ldr version was generated, and running make check
with subdirs=string.
r~
NEWS | 2 +-
ports/ChangeLog.arm | 6 ++++++
ports/sysdeps/arm/armv6/strcpy.S | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 3068b78..99c0c94 100644
--- a/NEWS
+++ b/NEWS
@@ -19,7 +19,7 @@ Version 2.18
15336, 15337, 15339, 15342, 15346, 15359, 15361, 15366, 15380, 15381,
15394, 15395, 15405, 15406, 15409, 15416, 15418, 15419, 15423, 15424,
15426, 15429, 15441, 15442, 15448, 15465, 15480, 15485, 15488, 15490,
- 15493, 15497, 15506, 15529, 15536, 15553.
+ 15493, 15497, 15506, 15529, 15536, 15553, 15583.
* CVE-2013-0242 Buffer overrun in regexp matcher has been fixed (Bugzilla
#15078).
diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm
index 4c73bb3..37eac21 100644
--- a/ports/ChangeLog.arm
+++ b/ports/ChangeLog.arm
@@ -1,3 +1,9 @@
+2013-06-05 Richard Henderson <rth@redhat.com>
+
+ [BZ #15583]
+ * sysdeps/arm/armv6/strcpy.S (strcpy): Fix register usage in
+ non ARCH_HAS_T2 case.
+
2013-06-05 Joseph Myers <joseph@codesourcery.com>
* sysdeps/arm/machine-gmon.h: Remove trailing whitespace.
diff --git a/ports/sysdeps/arm/armv6/strcpy.S b/ports/sysdeps/arm/armv6/strcpy.S
index cd13ff7..69e82d8 100644
--- a/ports/sysdeps/arm/armv6/strcpy.S
+++ b/ports/sysdeps/arm/armv6/strcpy.S
@@ -89,7 +89,7 @@ ENTRY (strcpy)
tst r0, #3 @ Test alignment of DEST
movt r7, #0x0101
#else
- ldr ip, =0x01010101
+ ldr r7, =0x01010101
tst r0, #3
#endif
bne .Lunaligned
--
1.8.1.4
reply other threads:[~2013-06-05 22:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370472686-3182-1-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).